Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/2078 store user credentials in localstorage #2088

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Improvement/2078 store user credentials in localstorage #2088

merged 2 commits into from
Dec 10, 2019

Conversation

ChengYanJin
Copy link
Contributor

Component: UI, Dex

Context:
We will want to share the user credentials across different tabs so that users won't need to be authenticated again.

Summary:
We set userStore: new WebStorageStateStore({ store: localStorage }), by default in userManagerConfig.

Acceptance criteria:
Once login, we should find the oidc.user:https://172.21.254.12:8443/oidc:metalk8s-ui oidc credential stored in localStorage.

Closes: #2078

@ChengYanJin ChengYanJin requested a review from a team as a code owner November 29, 2019 15:05
@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2019

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin
Copy link
Contributor Author

/after_pull_request=2042

@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2019

Waiting for other pull request(s)

The current pull request is locked by the after_pull_request option.

In order for me to merge this pull request, run the following actions first:

➡️ Merge the OPEN pull request:

Alternatively, delete all the after_pull_request comments from this pull request.

The following options are set: after_pull_request

@ChengYanJin ChengYanJin force-pushed the improvement/2078-store-user-credentials-in-localstorage branch from 37b1cc8 to 51be9e8 Compare November 29, 2019 15:24
@ChengYanJin ChengYanJin force-pushed the improvement/2078-store-user-credentials-in-localstorage branch from 51be9e8 to fa0aa3f Compare December 8, 2019 20:16
@bert-e
Copy link
Contributor

bert-e commented Dec 8, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: after_pull_request

@ChengYanJin ChengYanJin force-pushed the improvement/2078-store-user-credentials-in-localstorage branch from fa0aa3f to 03a282a Compare December 8, 2019 20:18
carlito-scality
carlito-scality suggested changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@carlito-scality carlito-scality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great but the logout button does not work anymore.

ui/package.json Outdated Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Dec 9, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

The following options are set: after_pull_request

@ChengYanJin ChengYanJin force-pushed the improvement/2078-store-user-credentials-in-localstorage branch from 03a282a to edbc5bb Compare December 9, 2019 14:12
@ChengYanJin
ui/authentication: store the user crediential in localstorage
ae9b200 
We will want to share the user crediential across different tabs.
By default redux-oidc storge access_token in sessionStorge,
in this PR we will change it to localStorage.

Refs: #2078
@ChengYanJin
ui/authentication: increase the limit the maxAssetSize
d5c14d6 
we add the oidc-client library so it's reach out the limit of assetsize
@ChengYanJin ChengYanJin force-pushed the improvement/2078-store-user-credentials-in-localstorage branch from edbc5bb to d5c14d6 Compare December 9, 2019 14:14
carlito-scality
carlito-scality approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@carlito-scality carlito-scality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebuilt and tested again. Everything is ok. I cannot reproduce the logout button problem.

@bert-e
Copy link
Contributor

bert-e commented Dec 10, 2019

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: after_pull_request

@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 10, 2019

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.5

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, after_pull_request

@bert-e
Copy link
Contributor

bert-e commented Dec 10, 2019

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.5

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4

Please check the status of the associated issue None.

Goodbye chengyanjin.

@bert-e bert-e merged commit d5c14d6 into development/2.5 Dec 10, 2019
@bert-e bert-e deleted the improvement/2078-store-user-credentials-in-localstorage branch December 10, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlito-scality carlito-scality carlito-scality approved these changes

@gdemonet gdemonet Awaiting requested review from gdemonet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChengYanJin @bert-e @carlito-scality