Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support salt 3000.2 #650

Closed
TeddyAndrieux opened this issue Feb 26, 2019 · 11 comments · Fixed by #2504
Closed

Support salt 3000.2 #650

TeddyAndrieux opened this issue Feb 26, 2019 · 11 comments · Fixed by #2504
Assignees
@TeddyAndrieux
Labels
topic:deployment Bugs in or enhancements to deployment stages

Comments

@TeddyAndrieux
Copy link
Collaborator

Currently salt 2019.2.0 is not supported as we use yaml information directly.
So unicode instead of string

https://docs.saltstack.com/en/latest/topics/releases/2019.2.0.html#non-backward-compatible-change-to-yaml-renderer

bootstrap: [ERROR   ] Command '[u'systemd-run', u'--scope', u'yum', u'-y', u'install', u"u'util-linux'", u"u'iptables'", u"u'iproute'"]' failed with return code: 1
    bootstrap: [ERROR   ] stdout: Running scope as unit run-396.scope.
    bootstrap: Loaded plugins: fastestmirror
    bootstrap: Loading mirror speeds from cached hostfile
    bootstrap:  * base: distrib-coffee.ipsl.jussieu.fr
    bootstrap:  * epel: mirror.ibcp.fr
    bootstrap:  * extras: centos.quelquesmots.fr
    bootstrap:  * updates: centos.mirrors.proxad.net
    bootstrap: No package u'util-linux' available.
    bootstrap: No package u'iptables' available.
    bootstrap: No package u'iproute' available.
    bootstrap: Error: Nothing to do
    bootstrap: [ERROR   ] retcode: 1
    bootstrap: [ERROR   ] Error occurred installing package(s). Additional info follows:
    bootstrap: 
    bootstrap: errors:
    bootstrap:     - Running scope as unit run-396.scope.
    bootstrap:       Loaded plugins: fastestmirror
    bootstrap:       Loading mirror speeds from cached hostfile
    bootstrap:        * base: distrib-coffee.ipsl.jussieu.fr
    bootstrap:        * epel: mirror.ibcp.fr
    bootstrap:        * extras: centos.quelquesmots.fr
    bootstrap:        * updates: centos.mirrors.proxad.net
    bootstrap:       No package u'util-linux' available.
    bootstrap:       No package u'iptables' available.
    bootstrap:       No package u'iproute' available.
    bootstrap:       Error: Nothing to do
    bootstrap: [ERROR   ] Command '[u'systemd-run', u'--scope', u'yum', u'-y', u'install', u"u'ethtool'", u"u'socat'", u"u'ebtables'", u"u'coreutils'", u"u'iproute'"]' failed with return code: 1
    bootstrap: [ERROR   ] stdout: Running scope as unit run-470.scope.
    bootstrap: Loaded plugins: fastestmirror
    bootstrap: Loading mirror speeds from cached hostfile
    bootstrap:  * base: distrib-coffee.ipsl.jussieu.fr
    bootstrap:  * epel: mirror.ibcp.fr
    bootstrap:  * extras: centos.quelquesmots.fr
    bootstrap:  * updates: centos.mirrors.proxad.net
    bootstrap: No package u'ethtool' available.
    bootstrap: No package u'socat' available.
    bootstrap: No package u'ebtables' available.
    bootstrap: No package u'coreutils' available.
    bootstrap: No package u'iproute' available.
    bootstrap: Error: Nothing to do
    bootstrap: [ERROR   ] retcode: 1
    bootstrap: [ERROR   ] Error occurred installing package(s). Additional info follows:
    bootstrap: 
    bootstrap: errors:
    bootstrap:     - Running scope as unit run-470.scope.
    bootstrap:       Loaded plugins: fastestmirror
    bootstrap:       Loading mirror speeds from cached hostfile
    bootstrap:        * base: distrib-coffee.ipsl.jussieu.fr
    bootstrap:        * epel: mirror.ibcp.fr
    bootstrap:        * extras: centos.quelquesmots.fr
    bootstrap:        * updates: centos.mirrors.proxad.net
    bootstrap:       No package u'ethtool' available.
    bootstrap:       No package u'socat' available.
    bootstrap:       No package u'ebtables' available.
    bootstrap:       No package u'coreutils' available.
    bootstrap:       No package u'iproute' available.
    bootstrap:       Error: Nothing to do
@TeddyAndrieux TeddyAndrieux added kind:bug Something isn't working topic:deployment Bugs in or enhancements to deployment stages moonshot labels Feb 26, 2019
@TeddyAndrieux TeddyAndrieux added this to the MetalK8s 2.0.0-alpha2 milestone Feb 26, 2019
@gdemonet gdemonet self-assigned this Mar 4, 2019
@NicolasT
Copy link
Contributor

NicolasT commented Mar 6, 2019

If we do this, I'd suggest we don't just "support" 2019.2.0, because in the end we (currently) own the whole stack, but go all the way and deploy those versions of master and minion as well.

@gdemonet
Copy link
Contributor

gdemonet commented Mar 7, 2019

Agreed, I'll also go further and deploy Python 3 versions as well (which in turn implies packaging of some dependencies, e.g. python34-kubernetes)

@gdemonet
Copy link
Contributor

gdemonet commented Mar 11, 2019 •
edited
Loading

Update: using Salt 2019.2.0 is currently blocked due to saltstack/salt#51869

It seems using Python 3 does not raise this bug, however it implies large amounts of packaging for dependencies missing in EPEL/Salt repository (in particular for the python-kubernetes client).

Thus, we will wait for a fix upstream and let the minions run in Python2, until #626 and #691 move all packaging needs to the Salt-master container only.

@gdemonet gdemonet added the state:blocked Something prevents this from being worked on label Mar 11, 2019
gdemonet added a commit that referenced this issue Mar 11, 2019
@gdemonet
Use Salt 2019.2.0
413d661 
Issue: GH-650
gdemonet added a commit that referenced this issue Mar 12, 2019
@gdemonet
Use Salt 2019.2.0
9a02164 
Issue: GH-650
@nootal nootal removed this from the MetalK8s 2.0.0-alpha2 milestone Mar 26, 2019
@TeddyAndrieux TeddyAndrieux removed the kind:bug Something isn't working label Apr 5, 2019
@NicolasT
Copy link
Contributor

NicolasT commented May 6, 2019

#626 and #691 are now closed.

@NicolasT
Copy link
Contributor

NicolasT commented May 6, 2019

Would it make sense to monkey-patch around this issue as hinted at in saltstack/salt#51869 (comment), or alternatively copy a 'fixed' version of the module/procedure in an extmod we ship?

I'd like to move forward with 2019.2 without waiting for 2019.2.1 being released, if possible...

@gdemonet
Copy link
Contributor

gdemonet commented May 6, 2019

I guess we can use the monkey-patch, since we already have our own metalk8s_kubernetes state module, why not one more?

@NicolasT
Copy link
Contributor

NicolasT commented May 6, 2019

Exactly.

At the same time, whenever we copy some code from Salt master or some later release, we should clearly tag this somehow in our code, such that whenever we move to a new Salt release, we can easily find those copies and remove them when applicable.

I failed to do so in the past myself, will do so in two places at least. Let's discuss to find a proper common format for this.

@shqnayaz
Copy link

shqnayaz commented Aug 1, 2019

HI Nicolas/Team,
I am trying to upgrade the ring from 6.4.5.10 to 7. in my local Lab
and when i run the upgrade script it fails

./upgrade

[2019-08-01 11:51:47+01:00] Update modules ... OK
[2019-08-01 11:51:49+01:00] Start repository HTTP server ... ERR: unable to apply Salt state scality.bootstrap.installed

where as all my minions are up
any suggestions please ?

@NicolasT
Copy link
Contributor

NicolasT commented Aug 1, 2019

Hello @shqnayaz,

Thanks for reaching out.

Your question relates to the installation/upgrade of Scality RING, which is a product not related to MetalK8s, the open-source project backed by Scality developed in this repository.

Please refer to the Scality RING documentation and the support channels available to you as a Scality customer so we can help you further.

Thank you,

Nicolas

@NicolasT
Copy link
Contributor

NicolasT commented Nov 5, 2019

The blocker is now fixed in upstream Salt releases v2019.2.1 and v2019.2.2.

@NicolasT NicolasT changed the title Support salt 2019.2.0 Support salt 2019.2.2 Nov 6, 2019
@NicolasT NicolasT removed the state:blocked Something prevents this from being worked on label Nov 6, 2019
NicolasT added a commit that referenced this issue Dec 18, 2019
@NicolasT
salt: use tojson when splicing in complex structures
0dbcbd1 
Sometimes we use a complex structure as an interpolated value in an SLS
file. Whilst this works, this is merely by accident, and Salt 2019.2
changes the behaviour: complex values would be spliced in using their
`unicode` representation, including `u""` markers.

As such, use a proper `tojson` filter in the Jinja templates instead.

See: #650
See: #650
See: https://docs.saltstack.com/en/latest/topics/releases/2019.2.0.html#non-backward-compatible-change-to-yaml-renderer
@NicolasT NicolasT mentioned this issue Dec 18, 2019
Merged
@gdemonet gdemonet mentioned this issue Apr 8, 2020
Merged
@gdemonet gdemonet changed the title Support salt 2019.2.2 Support salt 2019.2.3 Apr 24, 2020
TeddyAndrieux added a commit that referenced this issue Apr 30, 2020
@TeddyAndrieux
build: Upgrade Salt to 3000.2
4d1b289 
Change salt-master image to salt 3000.2 and download salt-minion version
3000.2

Fixes: #650
TeddyAndrieux added a commit that referenced this issue Apr 30, 2020
@TeddyAndrieux
build: Upgrade Salt to 3000.2
1039d12 
Change salt-master image to salt 3000.2 and download salt-minion version
3000.2

Fixes: #650
@TeddyAndrieux TeddyAndrieux mentioned this issue Apr 30, 2020
Merged
TeddyAndrieux pushed a commit that referenced this issue Apr 30, 2020
@NicolasT @TeddyAndrieux
salt: use tojson when splicing in complex structures
2263bc1 
Sometimes we use a complex structure as an interpolated value in an SLS
file. Whilst this works, this is merely by accident, and Salt 2019.2
changes the behaviour: complex values would be spliced in using their
`unicode` representation, including `u""` markers.

As such, use a proper `tojson` filter in the Jinja templates instead.

See: #650
See: #650
See: https://docs.saltstack.com/en/latest/topics/releases/2019.2.0.html#non-backward-compatible-change-to-yaml-renderer
(cherry picked from commit 0dbcbd1)
TeddyAndrieux added a commit that referenced this issue Apr 30, 2020
@TeddyAndrieux
build: Upgrade Salt to 3000.2
203aa01 
Change salt-master image to salt 3000.2 and download salt-minion version
3000.2

Fixes: #650
TeddyAndrieux added a commit that referenced this issue Apr 30, 2020
@TeddyAndrieux
build: Upgrade Salt to 3000.2
b01769f 
Change salt-master image to salt 3000.2 and download salt-minion version
3000.2

Fixes: #650
TeddyAndrieux added a commit that referenced this issue Apr 30, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/improvement/GH-650-upgrade-to-sa…
c8a9792 
…lt-3000' into w/2.1/improvement/GH-650-upgrade-to-salt-3000
bert-e added a commit that referenced this issue Apr 30, 2020
@bert-e
Merge branch 'w/2.2/improvement/GH-650-upgrade-to-salt-3000' into tmp…
56724c2 
…/octopus/w/2.3/improvement/GH-650-upgrade-to-salt-3000
TeddyAndrieux added a commit that referenced this issue Apr 30, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/w/2.3/improvement/GH-650-upgrade…
47e55bb 
…-to-salt-3000' into w/2.4/improvement/GH-650-upgrade-to-salt-3000
TeddyAndrieux added a commit that referenced this issue Apr 30, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/w/2.3/improvement/GH-650-upgrade…
27a5ab1 
…-to-salt-3000' into w/2.4/improvement/GH-650-upgrade-to-salt-3000
TeddyAndrieux added a commit that referenced this issue May 4, 2020
@TeddyAndrieux
build: Upgrade Salt to 3000.2
b296660 
Change salt-master image to salt 3000.2 and download salt-minion version
3000.2

Fixes: #650
TeddyAndrieux added a commit that referenced this issue May 4, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/improvement/GH-650-upgrade-to-sa…
ab218db 
…lt-3000' into w/2.1/improvement/GH-650-upgrade-to-salt-3000
bert-e added a commit that referenced this issue May 4, 2020
@bert-e
Merge branch 'w/2.2/improvement/GH-650-upgrade-to-salt-3000' into tmp…
dafe4fd 
…/octopus/w/2.3/improvement/GH-650-upgrade-to-salt-3000
TeddyAndrieux added a commit that referenced this issue May 4, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/w/2.3/improvement/GH-650-upgrade…
252fc4a 
…-to-salt-3000' into w/2.4/improvement/GH-650-upgrade-to-salt-3000
TeddyAndrieux added a commit that referenced this issue May 4, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/w/2.4/improvement/GH-650-upgrade…
f6bcb9c 
…-to-salt-3000' into w/2.5/improvement/GH-650-upgrade-to-salt-3000
bert-e added a commit that referenced this issue May 4, 2020
@bert-e
Merge branch 'w/2.4/improvement/GH-650-upgrade-to-salt-3000' into tmp…
d5a5e7f 
…/octopus/w/2.5/improvement/GH-650-upgrade-to-salt-3000
TeddyAndrieux added a commit that referenced this issue May 4, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/w/2.4/improvement/GH-650-upgrade…
84d0c59 
…-to-salt-3000' into w/2.5/improvement/GH-650-upgrade-to-salt-3000
TeddyAndrieux added a commit that referenced this issue May 4, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/w/2.5/improvement/GH-650-upgrade…
d4276b5 
…-to-salt-3000' into w/2.6/improvement/GH-650-upgrade-to-salt-3000
TeddyAndrieux added a commit that referenced this issue May 4, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/w/2.4/improvement/GH-650-upgrade…
1d20b01 
…-to-salt-3000' into w/2.5/improvement/GH-650-upgrade-to-salt-3000
TeddyAndrieux added a commit that referenced this issue May 4, 2020
@TeddyAndrieux
Merge remote-tracking branch 'origin/w/2.5/improvement/GH-650-upgrade…
44d3840 
…-to-salt-3000' into w/2.6/improvement/GH-650-upgrade-to-salt-3000
bert-e added a commit that referenced this issue May 5, 2020
@bert-e
Merge branch 'w/2.1/improvement/GH-650-upgrade-to-salt-3000' into tmp…
0afe48e 
…/octopus/w/2.2/improvement/GH-650-upgrade-to-salt-3000
bert-e added a commit that referenced this issue May 5, 2020
@bert-e
Merge branch 'w/2.5/improvement/GH-650-upgrade-to-salt-3000' into tmp…
79745eb 
…/octopus/q/2.5
bert-e added a commit that referenced this issue May 5, 2020
@bert-e
Merge branches 'w/2.6/improvement/GH-650-upgrade-to-salt-3000' and 'q…
3a69161 
…/2504/2.5/improvement/GH-650-upgrade-to-salt-3000' into tmp/octopus/q/2.6
@bert-e bert-e closed this as completed in 6e9bbfd May 5, 2020
gdemonet added a commit that referenced this issue May 12, 2020
@gdemonet
salt/solutions: Fix Operator Role rendering
cca641e 
With the introduction of Salt 3000, strings are converted to unicode by
default (hence, are not well rendered through Jinja without a `tojson`
filter).
This should not be needed once #2389 is done.

See: #650
@gdemonet gdemonet mentioned this issue May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeddyAndrieux TeddyAndrieux

Labels
topic:deployment Bugs in or enhancements to deployment stages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Salt 3000.2 python2 scality/metalk8s
5 participants
@NicolasT @nootal @shqnayaz @TeddyAndrieux @gdemonet