Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform K8s API operations from Salt master #691

Closed
NicolasT opened this issue Mar 1, 2019 · 2 comments
Closed

Perform K8s API operations from Salt master #691

NicolasT opened this issue Mar 1, 2019 · 2 comments
Labels
kind:enhancement New feature or request topic:deployment Bugs in or enhancements to deployment stages

Comments

@NicolasT
Copy link
Contributor

NicolasT commented Mar 1, 2019

So, here's the deal: currently, we run all these states on the bootstrap minion, which may be fine, but is not OK once we grow the cluster and such. The rationale is simple: this state (and others) should run just once.

This relates to #626 which would allow us to run this state only once, on the Salt master. In order for that to work, the master indeed needs creds, and ideally those are referred to from its configuration file, which we can do.

As to which creds to use: I'd like to create a ClusterRole and a Role that grants whatever access the Salt master requires to do its job (we can create those using the admin creds), then create a cert for the Salt master with bindings to said (Cluster)Role. That way, we can deploy Salt master(s) without handing out any non-required authorizations.

Originally posted by @NicolasT in #689

@NicolasT NicolasT added kind:enhancement New feature or request topic:deployment Bugs in or enhancements to deployment stages moonshot labels Mar 1, 2019
@NicolasT NicolasT added this to the MetalK8s 2.0.0-alpha2 milestone Mar 1, 2019
@nootal nootal removed this from the MetalK8s 2.0.0-alpha2 milestone Mar 26, 2019
@gdemonet gdemonet added this to the MetalK8s 2.0.0-beta1 milestone Apr 2, 2019
@NicolasT
Copy link
Contributor Author

NicolasT commented May 3, 2019

I believe this is done now, right @TeddyAndrieux ?

@TeddyAndrieux
Copy link
Collaborator

Yes I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:enhancement New feature or request topic:deployment Bugs in or enhancements to deployment stages
Projects
None yet
Development

No branches or pull requests

4 participants