-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store the access_token in the localStorage #2078
Labels
complexity:medium
Something that requires one or few days to fix
topic:authentication
Anything related to user authentication
topic:ui
UI-related issues
Milestone
Comments
ChengYanJin
added
moonshot
topic:ui
UI-related issues
complexity:medium
Something that requires one or few days to fix
topic:authentication
Anything related to user authentication
labels
Nov 26, 2019
ChengYanJin
added a commit
that referenced
this issue
Nov 29, 2019
We need to use WebStorageStateStore provided by oidc-client in order to store the credential in localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Nov 29, 2019
We will want to share the user crediential across different tabs. By default redux-oidc storge access_token in sessionStorge, in this PR we will change it to localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Nov 29, 2019
We need to use WebStorageStateStore provided by oidc-client in order to store the credential in localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Nov 29, 2019
We will want to share the user crediential across different tabs. By default redux-oidc storge access_token in sessionStorge, in this PR we will change it to localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Dec 8, 2019
We need to use WebStorageStateStore provided by oidc-client in order to store the credential in localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Dec 8, 2019
We will want to share the user crediential across different tabs. By default redux-oidc storge access_token in sessionStorge, in this PR we will change it to localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Dec 8, 2019
We need to use WebStorageStateStore provided by oidc-client in order to store the credential in localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Dec 8, 2019
We will want to share the user crediential across different tabs. By default redux-oidc storge access_token in sessionStorge, in this PR we will change it to localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Dec 9, 2019
We need to use WebStorageStateStore provided by oidc-client in order to store the credential in localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Dec 9, 2019
We will want to share the user crediential across different tabs. By default redux-oidc storge access_token in sessionStorge, in this PR we will change it to localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Dec 9, 2019
We will want to share the user crediential across different tabs. By default redux-oidc storge access_token in sessionStorge, in this PR we will change it to localStorage. Refs: #2078
ChengYanJin
added a commit
that referenced
this issue
Dec 17, 2019
We will want to share the user crediential across different tabs. By default redux-oidc storge access_token in sessionStorge, in this PR we will change it to localStorage. Refs: #2078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
complexity:medium
Something that requires one or few days to fix
topic:authentication
Anything related to user authentication
topic:ui
UI-related issues
Component: Dex, ui
Why this is needed:
After login, if we open another tab in the same browser, we are redirected to the login page again.
What should be done:
The hint is to change the user data into localStorage instead of sessionStorage, which is the current case for redux-oidc library. (But we still need to investigate if this is the real issue)
According to the suggestion of the redux-oidc git, we will need to look at the
oidc-client documentation
when configuring the userManager.oidc-client documentation
https://github.com/IdentityModel/oidc-client-js/wiki#configuration
Implementation proposal (strongly recommended):
TBD
Test plan:
TBD
The text was updated successfully, but these errors were encountered: