Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements #1767

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Conversation

poslegm
Copy link
Collaborator

@poslegm poslegm commented Mar 6, 2020

Attempt to clarify sbt integration versioning by .scalafmt.conf example near to plugin installation section.

Also rewriteTokens: incredibly useful config still not presented on the site.

Grammar check, please :)

Related to #1523

@poslegm poslegm requested review from kitbellew and tanishiking March 6, 2020 20:59
@poslegm poslegm changed the title Documentation Improvements Documentation improvements Mar 6, 2020
@@ -115,13 +115,19 @@ in the `.scalafmt.conf` configuration file and downloaded dynamically.

```scala
// In project/plugins.sbt. Note, does not support sbt 0.13, only sbt 1.x.
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.2.1")
// or
addSbtPlugin("com.geirsson" % "sbt-scalafmt" % "1.5.1") // before 1.6.0-RC4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose enough time has passed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@@ -115,13 +115,19 @@ in the `.scalafmt.conf` configuration file and downloaded dynamically.

```scala
// In project/plugins.sbt. Note, does not support sbt 0.13, only sbt 1.x.
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.2.1")
// or
addSbtPlugin("com.geirsson" % "sbt-scalafmt" % "1.5.1") // before 1.6.0-RC4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@poslegm poslegm merged commit 90025b5 into scalameta:master Mar 6, 2020
@poslegm poslegm deleted the sbt-related-docs branch March 6, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants