Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete configs documentation #1523

Closed
poslegm opened this issue Oct 11, 2019 · 4 comments
Closed

Complete configs documentation #1523

poslegm opened this issue Oct 11, 2019 · 4 comments

Comments

@poslegm
Copy link
Collaborator

poslegm commented Oct 11, 2019

I was a witness and participant of scalafmt adoption into a few large codebases and it always caused the developers to study the scalafmt sources for optimal configuration selection. In my opinion software should not force users to read source code (even if users is programmers).

In my sweet dreams configuration page in docs contains examples for all available options from .scalafmt.conf.

I propose two things:

  1. Step-by-step increase documentation coverage for scalafmt settings
  2. Don't merge PRs with new features without documentation

Are there any reasons why we shouldn't do this?

@tanishiking
Copy link
Member

It must be a good idea to increase the documentation coverage. 👍

If we add a lot of examples, we may want to decide "recommended / popular" configs and "minor" configs so that users don't need to consider too much about which ones should they configure.

@olafurpg
Copy link
Member

The undocumented configuration options are intentionally not documented since they are usually not well tested or supported. Maybe we should remove the undocumented settings from the source code rather than adding them to the website 😅

kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 19, 2020
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 19, 2020
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 19, 2020
kitbellew added a commit that referenced this issue Feb 19, 2020
@kitbellew
Copy link
Collaborator

@poslegm anything still missing in documentation?

@poslegm
Copy link
Collaborator Author

poslegm commented Oct 6, 2020

I think that all notable features are documented now. So, this issue can be closed.

Documentation quality increased a lot over the past year

@poslegm poslegm closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants