Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to format file due to bug in scalafmt with 2.4.0 & 2.4.1 #1717

Closed
bjaglin opened this issue Feb 17, 2020 · 0 comments · Fixed by #1729
Closed

Unable to format file due to bug in scalafmt with 2.4.0 & 2.4.1 #1717

bjaglin opened this issue Feb 17, 2020 · 0 comments · Fixed by #1729
Assignees
@kitbellew

Comments

@bjaglin
Copy link
Member

bjaglin commented Feb 17, 2020

  • Version: 2.4.0, 2.4.1
  • Integration: sbt-scalafmt
  • Configuration:
version = 2.4.1
maxColumn = 100

Steps

Given code like this:

class Bar {
  def foo(request: Request): RpcResult[Response] = {
    repository
      .flatMap { campaigns =>
        request match {
          case Nil => connection.pure(Right(toResponse(campaigns, Map.empty)))
          case _ =>
            getProfileEmails(request.securityContext, profileIds).to[ConnectionIO].map {
              profileEmails =>
                Right(toResponse(campaigns, profileEmails))
            }
        }
      }.transact(managerTransactor)
  }
}

When I run scalafmt like this:

sbt scalafmtAll

Problem

Scalafmt fails:

Bar.scala:12: error: Unable to format file due to bug in scalafmt

Expectation

I would like the file to be reformatted

Workaround

Stick to 2.3.2
@kitbellew kitbellew self-assigned this Feb 17, 2020
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
Add failing "unable to format due to bug" tests
e02df91 
See scalameta#448, scalameta#1462, scalameta#1485, scalameta#1559 and scalameta#1717.
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
7caa9e2 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and and a dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's inject states into the priority
queue with a generation value and decrement it on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes scalameta#448. Fixes scalameta#1462. Fixes scalameta#1485. Fixes scalameta#1599. Fixes scalameta#1717.
@kitbellew kitbellew mentioned this issue Feb 21, 2020
Merged
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
Add failing "unable to format due to bug" tests
cd24e91 
See scalameta#448, scalameta#1462, scalameta#1485, scalameta#1599 and scalameta#1717.
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
f278a50 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and the dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's inject states into the priority
queue with a generation value and increment it on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes scalameta#448. Fixes scalameta#1462. Fixes scalameta#1485. Fixes scalameta#1599. Fixes scalameta#1717.
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
06237f2 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and the dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's inject states into the priority
queue with a generation value and increment it on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes scalameta#448. Fixes scalameta#1462. Fixes scalameta#1485. Fixes scalameta#1599. Fixes scalameta#1717.
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
b59dd4b 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and the dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's maintain several generations of
priority queues and create a new generation on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes scalameta#448. Fixes scalameta#1462. Fixes scalameta#1485. Fixes scalameta#1599. Fixes scalameta#1717.
kitbellew added a commit that referenced this issue Feb 21, 2020
@kitbellew
Add failing "unable to format due to bug" tests
ebf3e3c 
See #448, #1462, #1485, #1599 and #1717.
kitbellew added a commit that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
9112af4 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and the dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's maintain several generations of
priority queues and create a new generation on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes #448. Fixes #1462. Fixes #1485. Fixes #1599. Fixes #1717.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitbellew kitbellew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BestFirstSearch: don't give up too soon kitbellew/scalafmt
2 participants
@bjaglin @kitbellew