Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to format file due to bug in Scalafmt #1599

Closed
olafurpg opened this issue Dec 13, 2019 · 2 comments · Fixed by #1722 or #1729
Closed

Unable to format file due to bug in Scalafmt #1599

olafurpg opened this issue Dec 13, 2019 · 2 comments · Fixed by #1722 or #1729
Labels
bug

Comments

@olafurpg
Copy link
Member

This template is a guideline, not a strict requirement.

  • Version: 2.3.2
  • Integration: cli
  • Configuration: default
version = 2.3.1

Steps

Given code like this:

object A {
  def foo() = {
    x.map(_.y(
      abcd,
      { case ((abcdefghij, aswbasdfaw), asfda) => aswdf},
      { case (abcdefghij, sadfasdass) => (asdfa.sadvfs(abcdefghij).get, asdfasdfasfdasda.asdfas(asdfasdaas).get) },
      foo
    ))
  }
}

When I run scalafmt like this:

scalafmt

Problem

Scalafmt formats code like this:

Caused by: org.scalafmt.Error$PreciseIncomplete: minimized.scala:6: error: Unable to format file due to bug in scalafmt
      { case (abcdefghij, sadfasdass) => (asdfa.sadvfs(abcdefghij).get, asdfasdfasfdasda.asdfas(asdfasdaas).get) },
                                                                                                           ^

Expectation

I would like scalafmt to format the file successfully.
@poslegm poslegm added the bug label Jan 25, 2020
@larsrh
Copy link

larsrh commented Feb 15, 2020

I just got this error in cats-effect:

[error] /home/lars/proj/typelevel/cats-effect/laws/shared/src/test/scala/cats/effect/IOTests.scala:315: error: Unable to format file due to bug in scalafmt
[error]       var effect = a
[error]                    ^: /home/lars/proj/typelevel/cats-effect/laws/shared/src/test/scala/cats/effect/IOTests.scala

... when trying to run scalafmt on typelevel/cats-effect#787

This was referenced Feb 15, 2020
Closed
Closed
@larsrh
Copy link

larsrh commented Feb 15, 2020

Same issue: typelevel/cats#3296

@rossabaker rossabaker mentioned this issue Feb 17, 2020
Closed
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 18, 2020
@kitbellew
Add the failing tests cited in issue scalameta#1599
18552ba
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 18, 2020
@kitbellew
FormatOps: in one-arg-per-line, handle lbrace case
f080da3 
Fixes scalameta#1599.
@kitbellew kitbellew mentioned this issue Feb 18, 2020
Merged
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
7caa9e2 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and and a dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's inject states into the priority
queue with a generation value and decrement it on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes scalameta#448. Fixes scalameta#1462. Fixes scalameta#1485. Fixes scalameta#1599. Fixes scalameta#1717.
@kitbellew kitbellew mentioned this issue Feb 21, 2020
Merged
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
Add failing "unable to format due to bug" tests
cd24e91 
See scalameta#448, scalameta#1462, scalameta#1485, scalameta#1599 and scalameta#1717.
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
f278a50 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and the dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's inject states into the priority
queue with a generation value and increment it on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes scalameta#448. Fixes scalameta#1462. Fixes scalameta#1485. Fixes scalameta#1599. Fixes scalameta#1717.
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
06237f2 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and the dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's inject states into the priority
queue with a generation value and increment it on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes scalameta#448. Fixes scalameta#1462. Fixes scalameta#1485. Fixes scalameta#1599. Fixes scalameta#1717.
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
b59dd4b 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and the dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's maintain several generations of
priority queues and create a new generation on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes scalameta#448. Fixes scalameta#1462. Fixes scalameta#1485. Fixes scalameta#1599. Fixes scalameta#1717.
kitbellew added a commit that referenced this issue Feb 21, 2020
@kitbellew
Add failing "unable to format due to bug" tests
ebf3e3c 
See #448, #1462, #1485, #1599 and #1717.
kitbellew added a commit that referenced this issue Feb 21, 2020
@kitbellew
BestFirstSearch: don't give up too soon
9112af4 
Currently, the algorithm would clear the search priority queue when the
top candidate points to a new statement. Sometimes this leads to losing
a viable path and the dreaded "Unable to format due to bug" error.

Rather than clearing the queue, let's maintain several generations of
priority queues and create a new generation on a new statement, thus
continuing to process subsequent states just like the old algorithm did
but with the previously discarded states available as backup.

Apply this modification to top-level invocations only, so that nested
calls will still terminate early; thus the backup candidates are really
processed at the very end of the existing logic.

Fixes #448. Fixes #1462. Fixes #1485. Fixes #1599. Fixes #1717.
kitbellew added a commit to kitbellew/scalafmt that referenced this issue Feb 24, 2020
@kitbellew
FormatOps: in one-arg-per-line, handle lbrace case
df37f40 
Fixes scalameta#1599.
kitbellew added a commit that referenced this issue Feb 24, 2020
@kitbellew
FormatOps: in one-arg-per-line, handle lbrace case
0270bb3 
Fixes #1599.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@larsrh @olafurpg @poslegm