bugfix: don't show scope completions for multi-imports #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciesluk
reviewed
Jan 4, 2024
| @@ -58,6 +60,7 @@ object CompletionPos: | |||
| val kind = | |||
| if query.isEmpty && !prevIsDot then CompletionKind.Empty | |||
There was a problem hiding this comment.
I believe we should check if !prevIsDot && !isImportSelect(cursorPos, treePath), so import scala.collection.{AbstractMap, @@} would work
There was a problem hiding this comment.
Where do we check it? Or do you mean we should check it here?
There was a problem hiding this comment.
Yes, I mean we should check it here
tgodzik
reviewed
Jan 4, 2024
| def loop(enclosing: List[Tree]): Boolean = | ||
| enclosing match | ||
| case head :: tl if !head.sourcePos.contains(pos) => loop(tl) | ||
| case Import(_, sel) :: _ => |
There was a problem hiding this comment.
Should this work in Export also?
| @@ -58,6 +60,7 @@ object CompletionPos: | |||
| val kind = | |||
| if query.isEmpty && !prevIsDot then CompletionKind.Empty | |||
There was a problem hiding this comment.
Where do we check it? Or do you mean we should check it here?
tgodzik
added a commit
to tgodzik/dotty
that referenced
this pull request
Jan 10, 2024
tgodzik
added a commit
to scala/scala3
that referenced
this pull request
Jan 11, 2024
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jun 27, 2024
This includes: - scalameta/metals#5956 - scalameta/metals#5979 - scalameta/metals#5994 - scalameta/metals#5995 - scalameta/metals#5998 - scalameta/metals#5999 - scalameta/metals#6000 [Cherry-picked 7240327]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5991