Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Backport changes from Metals #19410

Merged
merged 1 commit into from
Jan 11, 2024
Merged

chore: Backport changes from Metals #19410

merged 1 commit into from
Jan 11, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jan 10, 2024

@tgodzik tgodzik added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Jan 10, 2024
@tgodzik tgodzik requested review from rochala and Kordyjan January 10, 2024 14:36
rochala
rochala approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@rochala rochala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw you don't need to add backport nominated any more. It is added automatically by CI to proper list.

@tgodzik tgodzik merged commit a954bc7 into scala:main Jan 11, 2024
19 checks passed
@tgodzik tgodzik deleted the backport1 branch January 11, 2024 16:28
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
@tgodzik tgodzik removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label May 8, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jun 27, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 28, 2024
@WojciechMazur
Backport "chore: Backport changes from Metals" to LTS (#20823)
6fe1132 
Backports #19410 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochala rochala rochala approved these changes

@Kordyjan Kordyjan Awaiting requested review from Kordyjan

Assignees
No one assigned
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tgodzik @rochala @Kordyjan