Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bloop - bump version #3818

Merged
merged 1 commit into from
Apr 12, 2022
Merged

bloop - bump version #3818

merged 1 commit into from
Apr 12, 2022

Conversation

dos65
Copy link
Member

@dos65 dos65 commented Apr 12, 2022

No description provided.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check my reproduction scenario and report back!

@tgodzik
Copy link
Contributor

tgodzik commented Apr 12, 2022

Works! Great work @dos65 !!!

@dos65 dos65 merged commit 5d64198 into scalameta:main Apr 12, 2022
@ckipp01
Copy link
Member

ckipp01 commented Apr 13, 2022

I will check my reproduction scenario and report back!

Just a curiosity, it sounds like this bump was fixing a specific issue? If so, what issue, and in the future can we include that info in the commit? It might be helpful for people that come across this later on or are trying to debug where something was introduced 😅 .

@tgodzik
Copy link
Contributor

tgodzik commented Apr 13, 2022

It fixes scalacenter/bloop#1720 which was causing issues when first compiling the workspace with already existing analyses.

@dos65
Copy link
Member Author

dos65 commented Apr 13, 2022

@ckipp01 it fixes an issue with changes detection but only for recent versions of bloop which comes with original zinc instead of fork. Metals wasn't released with this version so this fix fall into category: upgraded bloop which doesn't use specific zinc fork anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants