fix: prevent ignorance of initial changes #1720
Conversation
| @@ -84,7 +84,10 @@ private final class BloopNameHashing( | |||
| initialChangedSources, | |||
| allSources.map(v => v: VirtualFileRef), | |||
| previous | |||
| ).collect { case f: VirtualFile => f } | |||
There was a problem hiding this comment.
initialChagedSources are received as VirtualFileRef and mapInvalidationToSources doesn't lift them into VirtualFile.
Using collect here is incorrect as it just drops correctly invalidated sources.
There was a problem hiding this comment.
och! That looks like the issue i've been having! Awesom!
| ).map { | ||
| case f: VirtualFile => f | ||
| case ref: VirtualFileRef => PlainVirtualFileConverter.converter.toVirtualFile(ref) | ||
| } |
There was a problem hiding this comment.
@tgodzik Is PlainVirtualFileConverter.converter usage fine here?
I've seen that in some methods converter is passed as parameter.
There was a problem hiding this comment.
I think so, we don't use any other converters currently, so this should be fine.
There was a problem hiding this comment.
what is the actual type returned? VirtualFileRef is only an interface, no?
| ).map { | ||
| case f: VirtualFile => f | ||
| case ref: VirtualFileRef => PlainVirtualFileConverter.converter.toVirtualFile(ref) | ||
| } |
There was a problem hiding this comment.
I think so, we don't use any other converters currently, so this should be fine.
| @@ -84,7 +84,10 @@ private final class BloopNameHashing( | |||
| initialChangedSources, | |||
| allSources.map(v => v: VirtualFileRef), | |||
| previous | |||
| ).collect { case f: VirtualFile => f } | |||
There was a problem hiding this comment.
och! That looks like the issue i've been having! Awesom!
No description provided.