Use ssh key saved in ssh-agent if deploy key env var is not set. Fixes #398 #400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@olafurpg Thanks for the pointer in #398, I think this should fix it.
DEPLOY_KEY
to empty string instead of throwing an error.if [[ -n "${DEPLOY_KEY:-}" ]]; then
. This checks thatDEPLOY_KEY
is set AND non-empty, so this check fails, and the code proceeds intoelse
, where a warning is printed.yarn install
etc. If you havessh-add
-ed an ssh key like I do locally, this will use that key, and your name & email (not docusaurus info fromset-up-ssh
), which... I guess is appropriate given that your personal key is used?This change works for me, I tested by running this script locally on bash 3.2.
I thought about updating the docs to indicate this new behaviour, but the way they read heavily implies this new behaviour already I think.