Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docusaurus plugin: usage without GIT_DEPLOY_KEY? #398

Closed
raquo opened this issue Oct 12, 2020 · 1 comment
Closed

Docusaurus plugin: usage without GIT_DEPLOY_KEY? #398

raquo opened this issue Oct 12, 2020 · 1 comment

Comments

@raquo
Copy link
Contributor

raquo commented Oct 12, 2020

Hello,

On my local computer I don't have GIT_DEPLOY_KEY env var defined, so I'm getting the error mentioned in #353 when trying to run website/docusaurusPublishGhpages.

I understand why GIT_DEPLOY_KEY makes sense for CI environments, but locally I can push to github using an ssh key I have already ssh-add-ed, and I can deploy my mdoc-docusaurus site manually using the command cd website && yarn install && USE_SSH=true yarn publish-gh-pages, without the need for GIT_DEPLOY_KEY.

Ideally I would like to use an sbt command like website/docusaurusPublishGhpages to achieve the same without the extra deploy key / environment variables setup, but it doesn't seem to be supported at the moment.

@olafurpg
Copy link
Member

Thank you for reporting! I'd be happy to merge a PR adding the ability publish to gh-pages directly from sbt. I haven't had the need for this functionality in my own projects since I prefer to always publish from CI (even if it's a tiny project with no users). I am OK with changing the script to do nothing if GIT_DEPLOY_KEY is empty in this script here

|DEPLOY_KEY=${GIT_DEPLOY_KEY:-$GITHUB_DEPLOY_KEY}

olafurpg added a commit that referenced this issue Oct 14, 2020
Use ssh key saved in ssh-agent if deploy key env var is not set. Fixes #398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants