Fix resolution of test-jar artifacts #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
changed the title
keynmol
commented
Jun 30, 2022
| artifact.getVersion() | ||
| ) | ||
| ) | ||
| request.setArtifact(RepositoryUtils.toArtifact(artifact)) |
There was a problem hiding this comment.
Reading https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/RepositoryUtils.java#L56-L60 I can see it's an internal tool and shouldn't be used, hence I will revert it.
Will need to duplicate some of its logic.
There was a problem hiding this comment.
Removed in 8a606df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: this is indeed a separate issue with the fix provided in 3a1d935
context:
The problem I saw is related to #1727, but in the case of a test-jar external dependency - it wasn't being added to test scope classpath at all.
While tinkering at it, I also noticed that manual translation between Aether and Maven'sTurns out it's not part of public API so it's better not to use it.Artifacttypes is not required, as there seems to be a method for that, used in Maven's own sources.And finally, I added a test to specifically verify that
<...>-tests.jaris resolved.I think this "fix" is somewhat different to #1727, and is worth a separate review.