Check for test-jar dependencies #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnd999
force-pushed
the
handle-test-jar-dependencies
branch
from
0bd7a7d to
826e5f2
Compare
When adding dependencies, check the project artifacts to see if there are any test-jar dependencies and if so, add the test project as a dependency as well.
mnd999
force-pushed
the
handle-test-jar-dependencies
branch
from
826e5f2 to
9f91e2b
Compare
tgodzik
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
LGTM! Do you have maybe a test project?
We could add it to the test resources and test in MavenConfigGenerationSuite
kpodsiad
reviewed
Apr 26, 2022
integrations/maven-bloop/src/main/scala/bloop/integrations/maven/MojoImplementation.scala
Outdated
Show resolved
Hide resolved
* Don't use :+
|
I've added the test project from the linked issue. |
tgodzik
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding dependencies, check the project artifacts to see if there
are any test-jar dependencies and if so, add the test project as a
dependency as well.
Fixes: #1669