Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Async IO for HttpsDataVault, Fox Error Handling" #7154

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jun 19, 2023

Reverts #7137

(WebknossosModule now needs DataVaultService, which does not work when there is no local datastore)

I will create a second try for that PR

@fm3 fm3 self-assigned this Jun 19, 2023
@fm3 fm3 requested a review from normanrz June 19, 2023 11:17
@fm3 fm3 enabled auto-merge (squash) June 19, 2023 11:18
@fm3 fm3 merged commit 723e207 into master Jun 19, 2023
@fm3 fm3 deleted the revert-7137-vault-read-fox branch June 19, 2023 11:34
fm3 added a commit that referenced this pull request Jun 19, 2023
fm3 added a commit that referenced this pull request Jun 19, 2023
* Revert "Revert "Async IO for HttpsDataVault, Fox Error Handling (#7137)" (#7154)"

This reverts commit 723e207.

* separate RemoteSourceDescriptorService and DataVaultService

* remove unused imports
hotzenklotz added a commit that referenced this pull request Jun 20, 2023
…esign-right-sidebar

* 'master' of github.com:scalableminds/webknossos:
  added Youtube videos to docs
  Log dataset uploads (with no conversion) to slack (#7157)
  Added "Automation Tutorial" to docs (#7160)
  fix logo image in README.md
  Second try for “Async IO for HttpsDataVault, Fox Error Handling” (#7155)
  Revert "Async IO for HttpsDataVault, Fox Error Handling (#7137)" (#7154)
  Async IO for HttpsDataVault, Fox Error Handling (#7137)
  Fix vault path for precomputed datasets (#7151)
  Add extended keyboard shortcut mode via ctrl + k for tool shortcuts (#7112)
  Shared Chunk Cache for all DatasetArrays, CacheWeight for AlfuCache (#7067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants