Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vault path for precomputed datasets #7151

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Fix vault path for precomputed datasets #7151

merged 3 commits into from
Jun 16, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Jun 16, 2023 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open any precomputed dataset (was broken previously)

Issues:

  • fixes #

(Please delete unneeded items, merge only when none are left open)

  • Updated changelog Necessary? Only fixes an issue introduced in the same release
  • Needs datastore update after deployment

@frcroth frcroth requested review from normanrz and fm3 June 16, 2023 11:16
normanrz
normanrz approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you have tested this for a selection of datasets

fm3
fm3 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh, this happend while resolving merge conflicts. sorry and thanks for the quick fix! (if this is the only usage of basePath, inlining magPath.parent would be nicer imo, but not important)

@frcroth frcroth merged commit 595bc8a into master Jun 16, 2023
@frcroth frcroth deleted the fix-precomputed-path branch June 16, 2023 13:36
hotzenklotz added a commit that referenced this pull request Jun 20, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into red…
bca04f0 
…esign-right-sidebar

* 'master' of github.com:scalableminds/webknossos:
  added Youtube videos to docs
  Log dataset uploads (with no conversion) to slack (#7157)
  Added "Automation Tutorial" to docs (#7160)
  fix logo image in README.md
  Second try for “Async IO for HttpsDataVault, Fox Error Handling” (#7155)
  Revert "Async IO for HttpsDataVault, Fox Error Handling (#7137)" (#7154)
  Async IO for HttpsDataVault, Fox Error Handling (#7137)
  Fix vault path for precomputed datasets (#7151)
  Add extended keyboard shortcut mode via ctrl + k for tool shortcuts (#7112)
  Shared Chunk Cache for all DatasetArrays, CacheWeight for AlfuCache (#7067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

@normanrz normanrz normanrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frcroth @normanrz @fm3