Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toggling "Render missing data black" when being logged out #6772

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Fix toggling "Render missing data black" when being logged out #6772

merged 3 commits into from
Jan 23, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 23, 2023 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • toggle Render missing data black in sidebar when being logged out
  • no error should occur

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jan 23, 2023
@philippotto philippotto requested a review from fm3 January 23, 2023 09:59
fm3
fm3 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks 🎉

@philippotto philippotto enabled auto-merge (squash) January 23, 2023 10:08
@philippotto philippotto merged commit 84fbe36 into master Jan 23, 2023
@philippotto philippotto deleted the fix-load-missing-data-setting branch January 23, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changing "render missing data black" setting causes an error while not logged in
2 participants
@philippotto @fm3