Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing "render missing data black" setting causes an error while not logged in #6769

Closed
3 tasks
thopp-tudelft opened this issue Jan 20, 2023 · 2 comments · Fixed by #6772
Closed
3 tasks
Assignees

Comments

@thopp-tudelft
Copy link

Context

viewing any dataset while not logged in

Expected Behavior

nothing

Current Behavior

image
a 401 and a 403 status are logged in the console

Steps to Reproduce the bug

  • Cannot reproduce the bug anymore / needs deeper investigation.
  1. log out of webknossos
  2. visit a dataset, eg https://webknossos.org/datasets/scalable_minds/l4dense_motta_et_al_demo
  3. click the settings tab
  4. toggle "render missing data black"

Your Environment for bug

  • Browser name and version: firefox 108.0.2
  • Operating System and version: Arch linux, kernel 6.1.6
  • Version of WebKnossos (Release or Commit): 23.01 or 21218
  • Specific to long-running jobs (set jobsEnabled=true in application.conf)
  • Specific to webknossos.org (set isDemoInstance=true in application.conf)
@fm3
Copy link
Member

fm3 commented Jan 23, 2023

Hi and thanks for your report! I can reproduce the behavior you described. We will have a look!

@philippotto Both the data/triggers/reload and clearThumbnailCache routes are not available to logged-out users (which I’d say is correct). The reload layer button is simply not available for logged-out users, solving this problem there. But changing “render missing data black“ triggers these requests too. Do you think we should disable the button completely? Or may it be worth the effort to skip the requests that mutate server state in this case?

@philippotto
Copy link
Member

Thanks for the report, @thopp-tudelft! Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants