Respect mail.smtp.auth setting

CHANGELOG.unreleased.md

@@ -28,6 +28,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
 - Fixed access of remote datasets using the Amazon S3 protocol [#6679](https://github.com/scalableminds/webknossos/pull/6679)
 - Fixed a bug in line measurement that would lead to an infinite loop. [#6689](https://github.com/scalableminds/webknossos/pull/6689)
 - Fixed a bug where malformed json files could lead to uncaught exceptions.[#6691](https://github.com/scalableminds/webknossos/pull/6691)
+- Respect the config value mail.smtp.auth (used to be ignored, always using true) [#6692](https://github.com/scalableminds/webknossos/pull/6692)
 
 ### Removed
 

app/Startup.scala

@@ -120,6 +120,7 @@ class Startup @Inject()(actorSystem: ActorSystem,
       conf.Mail.Smtp.host,
       conf.Mail.Smtp.port,
       conf.Mail.Smtp.tls,
+      conf.Mail.Smtp.auth,
       conf.Mail.Smtp.user,
       conf.Mail.Smtp.pass,
     )

app/oxalis/mail/Mailer.scala

@@ -20,6 +20,7 @@ case class MailerConfig(
     smtpHost: String,
     smtpPort: Int,
     smtpTls: Boolean,
+    smtpAuth: Boolean,
     smtpUser: String,
     smtpPass: String,
 )
@@ -54,7 +55,9 @@ class Mailer(conf: MailerConfig) extends Actor with LazyLogging {
       multiPartMail.setHostName(conf.smtpHost)
       multiPartMail.setSmtpPort(conf.smtpPort)
       multiPartMail.setStartTLSEnabled(conf.smtpTls)
-      multiPartMail.setAuthenticator(new DefaultAuthenticator(conf.smtpUser, conf.smtpPass))
+      if (conf.smtpAuth) {
+        multiPartMail.setAuthenticator(new DefaultAuthenticator(conf.smtpUser, conf.smtpPass))
+      }
       multiPartMail.setDebug(false)
       multiPartMail.getMailSession.getProperties.put("mail.smtp.ssl.protocols", "TLSv1.2")
 
@@ -69,17 +72,16 @@ class Mailer(conf: MailerConfig) extends Actor with LazyLogging {
   /**
     * Extracts an email address from the given string and passes to the enclosed method.
     */
-  private def setAddress(emailAddress: String)(setter: (String, String) => _) {
+  private def setAddress(emailAddress: String)(setter: (String, String) => _): Unit =
     try {
       val iAddress = new InternetAddress(emailAddress)
       val address = iAddress.getAddress
       val name = iAddress.getPersonal
 
       setter(address, name)
     } catch {
-      case _: Exception => ()
+      case e: Exception => logger.warn(s"Failed to set email address: $e")
     }
-  }
 
   /**
     * Creates an appropriate email object based on the content type.

conf/application.conf

@@ -181,7 +181,6 @@ mail {
     pass = ""
   }
   defaultSender = "webKnossos <[email protected]>"
-  reply = "webKnossos <[email protected]>"
   mailchimp {
     host = ""
     listId = ""