Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect mail.smtp.auth setting #6692

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Respect mail.smtp.auth setting #6692

merged 4 commits into from
Dec 13, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Dec 9, 2022 •
edited
Loading

As reported in #6688 the wk setting mail.smtp.auth was not respected. I added an if-condition to only set the auth fields if this is enabled.
The PR also adds some logging if email adresses could not be set.

@fm3 fm3 self-assigned this Dec 9, 2022
@fm3 fm3 added backend and removed automerge labels Dec 12, 2022
@thopp-tudelft thopp-tudelft mentioned this pull request Dec 13, 2022
Closed
@fm3 fm3 marked this pull request as ready for review December 13, 2022 14:57
@fm3 fm3 requested a review from jstriebel December 13, 2022 15:00
jstriebel
jstriebel approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fm3 fm3 merged commit 6469d1d into master Dec 13, 2022
@fm3 fm3 deleted the email-auth-setting branch December 13, 2022 18:58
hotzenklotz added a commit that referenced this pull request Dec 15, 2022
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into pri…
411959d 
…cing

* 'master' of github.com:scalableminds/webknossos:
  Respect mail.smtp.auth setting (#6692)
  Implement multi selection of datasets in folder tab (#6683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

Assignees

@fm3 fm3

Labels
backend bug infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @jstriebel