Integrate Rome Linting #6618
Merged
Integrate Rome Linting #6618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
approved these changes
Nov 10, 2022
| @@ -180,7 +172,6 @@ | |||
| "deep-freeze": "0.0.1", | |||
| "dice-coefficient": "^2.1.0", | |||
| "distance-transform": "^1.0.2", | |||
| "eslint-plugin-ava": "^13.2.0", | |||
There was a problem hiding this comment.
There's probably no replacement for the ava https://github.com/avajs/eslint-plugin-ava/blob/main/docs/rules/no-only-test.md, right? I remember that we added this one just recently, because we got bitten by that.
There was a problem hiding this comment.
Good point! I replaced it with a very simplistic bash file: 11fbb92
It's not super accurate (since the only modifier could be formulated in another way), but I think it should catch 95% of the cases :)
hotzenklotz
added a commit
that referenced
this pull request
Nov 15, 2022
…knossos into pricing * 'pricing' of github.com:scalableminds/webknossos: * 'master' of github.com:scalableminds/webknossos: Release 22.11.2 (#6629) Encode layer visibility in sharing link (#6634) Allow viewing vx workflows via link if organization matches (#6622) Hotfix: increase zarr chunk cache size (#6639) Integrate Rome Linting (#6618) Fix task creation with base NML (#6635) Fix NGFF import for datasets with no channel axis (#6637)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates rome linter and disables eslint except for the rules-of-hooks which are not yet supported by rome unfortunately. Nevertheless, the CI time is reduced by ~30s. Once we integrate rome formatting, we can shave of another 10 seconds.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)