Fix task creation with base NML #6635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
philippotto
approved these changes
Nov 14, 2022
philippotto
pushed a commit
that referenced
this pull request
Nov 14, 2022
hotzenklotz
added a commit
that referenced
this pull request
Nov 15, 2022
…knossos into pricing * 'pricing' of github.com:scalableminds/webknossos: * 'master' of github.com:scalableminds/webknossos: Release 22.11.2 (#6629) Encode layer visibility in sharing link (#6634) Allow viewing vx workflows via link if organization matches (#6622) Hotfix: increase zarr chunk cache size (#6639) Integrate Rome Linting (#6618) Fix task creation with base NML (#6635) Fix NGFF import for datasets with no channel axis (#6637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the frontend now also sends the id with the json key taskTypeIdOrSummary in the createFromFiles case. This PR renames the expected backend parameter to match that.
It does not, however, allow for summaries, this would have made the code quite a bit more complicated.
I’m starting to think that this whole IdOrSummary thing may have been a mistake (as in, the harder-to-maintain code is not justified by the small ux improvement). Let’s discuss that in person next week.
URL of deployed dev instance (used for testing):
Steps to test: