Avoid proofreading actions while the last one is not finished #6325
Conversation
| @@ -234,7 +234,7 @@ class SynapseTree extends React.Component<Props, State> { | |||
| <Dropdown // Lazily create the dropdown menu and destroy it again, afterwards | |||
| overlay={() => this.createSegmentDropdownMenu(data.id)} | |||
| autoDestroy | |||
| placement="bottomCenter" | |||
| placement="bottom" | |||
There was a problem hiding this comment.
Saw this deprecation warning: Warning: [antd: Dropdown] You are using 'bottomCenter' placement in Dropdown, which is deprecated. Try to use 'bottom' instead.
There was a problem hiding this comment.
Looks good to me 🎉.
I only got one point, where I was unsure whether the deletion of a line was intentional. I'll approve anyway so you can directly merge when this was intentional. Otherwise might need to wait a bit again until I can approve :)
I only managed to sometimes load a proofreading annotation where the hdf5 mapping was already loaded directly after opening the annotation. But the proofreading tool was not visible in the toolbar. Only after I switched the mapping, the proofreading tool was visible. I think this is unrelated but still a bug, right?
| // Undo the last splitting/merging action since the proofreading action did not succeed | ||
| yield* put(undoAction()); |
There was a problem hiding this comment.
Why do we no longer undo the action when the call failed?
There was a problem hiding this comment.
This was an oversight while merging the original proofreading PR. Undo/Redo is actually not allowed if the proofreading tool is active and a warning in that regard is shown to the user if it is triggered. This was added kind of last-minute, because the actual proofreading actions cannot be undone yet. Unfortunately, that's why this line had to be removed for now.
|
Thanks a lot for the review!
This sounds like a bug, I'll have a look :) |
|
@MichaelBuessemeyer Thanks again for indicating the buggy behavior. I've pushed a fix :) To reproduce, make sure the an agglomerate view mapping is activated and the mapping selection tab is not visible when reloading the page - that's what reliably triggered the bug before. |
Set wk busy during proofreading and also modify the input catchers so that they not only show a loading spinner if wk is busy, but actually block all inputs.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)