Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter precedence when creating task from base #6249

Merged
merged 6 commits into from
Jun 10, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 31, 2022

When creating a task from a base annotation, the starting position/rotation and bounding box as specified during task creation are now used and overwrite the ones from the original base annotation.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create an explorative annotation, trace some, copy id
  • Create a task, select base annotation, insert above id
  • When requesting the task, you should start at the edit position + rotation as specified during task creation, not the ones from said explorative annotation.

Issues:


@fm3 fm3 self-assigned this May 31, 2022
@fm3 fm3 marked this pull request as ready for review May 31, 2022 11:52
@fm3 fm3 changed the title [WIP] Change parameter precedence when creating task from base Change parameter precedence when creating task from base May 31, 2022
@fm3 fm3 requested a review from leowe May 31, 2022 11:52
@fm3 fm3 requested a review from jstriebel June 7, 2022 11:28
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the new refactorings! LGTM 🚢

@fm3 fm3 merged commit 03e565b into master Jun 10, 2022
@fm3 fm3 deleted the task-base-parameters branch June 10, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect "Starting Position" in task when using an Annotation ID as Base
2 participants