Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect "Starting Position" in task when using an Annotation ID as Base #6200

Closed
3 tasks
philippotto opened this issue May 10, 2022 · 2 comments · Fixed by #6249
Closed
3 tasks

Respect "Starting Position" in task when using an Annotation ID as Base #6200

philippotto opened this issue May 10, 2022 · 2 comments · Fixed by #6249
Assignees

Comments

@philippotto
Copy link
Member

Context

Tasks with a base annotation will always use the edit position from that base annotation instead of the one which is provided when creating a task.

Steps to Reproduce the bug

  • Cannot reproduce the bug anymore / needs deeper investigation.
  1. Create a new task type with volume enabled
  2. Create an annotation, go to position 100, 100, 100, save and copy its id
  3. Create a new task, select the task type from (1) and select "Use Annotation ID as Base" where the id from (2) should be pasted in
  4. Enter a Starting Position (e.g., 1, 2, 3)
  5. Go to dashboard, get a new task and open it
  6. The active position should be the one from (4). Instead, it is 100, 100, 100.

Your Environment for bug

  • Browser name and version: e.g. Chrome 39
  • Operating System and version: e.g. Windows 10
  • Version of WebKnossos (Release or Commit):
  • Specific to long-running jobs (set jobsEnabled=true in application.conf)
  • Specific to webKnossos.org (set isDemoInstance=true in application.conf)
@fm3
Copy link
Member

fm3 commented May 31, 2022

Should the same go for bounding box and edit rotation? I’d guess so, right?

@philippotto
Copy link
Member Author

For the edit rotation, yes, I'd say so. For the bounding box, we usually differentiate between the task bounding box and dataset/annotation bounding box. I didn't check what the current behavior with an annotation base is, but it should probably use the bounding box from the task form as the task bounding box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants