-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework volume interpolation feature to be shortcut-bound and support depths > 2 #6235
Conversation
…o rely on the hovered plane
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR 🎉 . Thanks for making the interpolation available for higher distances 📐 .
Codewise I only found some minor things.
Bugs I noticed. I tested on the dev instance in this tracing:
- In resolution 8-8-2 I drew on one slice in the xy viewport, and moved two slices forward by pressing space two times. Then I annotated a little again. Now the interpolation button is disabled (which imo shouldn't be the case) and when I press
v
I get theCould not interpolate segment because last labeled slice should be at least 2 slices away
error message. In the described scenario the two annotated slices should be far enough away from each other for the interpolation to work, right? So I think this is a bug. While reading the code I could not spot why this might be the case.
Usability nice to haves:
- When the interpolation button is disabled, the button is only disabled. There is no tooltip telling why the button is disabled. I would like to have an explanatory tooltip.
- I don't know whether it is by design, but the volume interpolation button is wider than the other tool buttons. Maybe it would look nicer if it would have the same length as the other tool buttons.
- There is no visual feedback on whether the interpolation is still being computed or already finished. Something like a little yellow dot for "I am still computing" and green for "I finished interpolating" would be nice imo.
frontend/javascripts/oxalis/model/sagas/volume/volume_interpolation_saga.ts
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/model/sagas/volume/volume_interpolation_saga.ts
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/model/sagas/volume/volume_interpolation_saga.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: MichaelBuessemeyer <[email protected]>
…he current mag effectively rounds the coordinates; fix wrong coordinate system for centroid when brushing with a single click
@MichaelBuessemeyer Thanks for your feedback! I think, I fixed all bugs (the wide button and missing toolbar was also a bug, caused by switching from
The mouse cursor should turn into a waiting cursor when wk is busy. I think, this generalizes better to a yellow dot or similar. However, I don't see that cursor (maybe the workload is not large enough?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing my address issues. I couldn't reproduce them anymore. 🚀
The mouse cursor should turn into a waiting cursor when wk is busy. I think, this generalizes better to a yellow dot or similar.
Ah, using the cursor as an indication sounds good.
However, I don't see that cursor (maybe the workload is not large enough?). takeEveryUnlessBusy should take care of this actually... If I got another second, I'll try to investigate,
Same here, for my setup (MacOS + Chrome). The cursor does not turn into a waiting-like symbol :/. It might actually be that the computation is too fast 🚀 .
but I'd hope that this doesn't block the PR.
Agreed, this is be something for a follow-up pr.
From changelog:
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)