Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing "ID mapping" dropdown #6215

Merged
merged 3 commits into from
May 17, 2022
Merged

Fix disappearing "ID mapping" dropdown #6215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b723b76
always show ID mapping dropdown
hotzenklotz May 17, 2022
a0d2e92
updated changelog
hotzenklotz May 17, 2022
3b81be1
fix linting
hotzenklotz May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Fixed a bug in the task creation, where creation for some tasks with initial volume data would fail. [#6178](https://github.com/scalableminds/webknossos/pull/6178)
- Fixed a bug in the task cration, where creation for some tasks with initial volume data would fail. [#6178](https://github.com/scalableminds/webknossos/pull/6178)
- Fixed a rendering bug which could cause an incorrect magnification to be rendered in rare scenarios. [#6029](https://github.com/scalableminds/webknossos/pull/6029)
- Fixed a bug which could cause a segmentation layer's "ID mapping" dropdown to disappear. [#6215](https://github.com/scalableminds/webknossos/pull/6215)

### Removed

Expand Down
7 changes: 0 additions & 7 deletions frontend/javascripts/oxalis/view/left-border-tabs/mapping_settings_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {
setHideUnmappedIdsAction,
setMappingAction,
} from "oxalis/model/actions/settings_actions";
import Model from "oxalis/model";
import { SwitchSetting } from "oxalis/view/components/setting_input_views";
import * as Utils from "libs/utils";
import { jsConvertCellIdToHSLA } from "oxalis/shaders/segmentation.glsl";
Expand Down Expand Up @@ -73,8 +72,6 @@ export const convertCellIdToCSS = (
) =>
id === 0 ? "transparent" : convertHSLAToCSSString(jsConvertCellIdToHSLA(id, customColors, alpha));

const hasSegmentation = () => Model.getVisibleSegmentationLayer() != null;

const needle = "##";

const packMappingNameAndCategory = (mappingName: string, category: MappingType) =>
Expand Down Expand Up @@ -170,10 +167,6 @@ class MappingSettingsView extends React.Component<Props, State> {
};

render() {
if (!hasSegmentation()) {
return <div className="padded-tab-content">No segmentation available</div>;
}

const availableMappings =
this.props.segmentationLayer != null && this.props.segmentationLayer.mappings != null
? this.props.segmentationLayer.mappings
Expand Down