Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing "ID mapping" dropdown #6215

Merged
merged 3 commits into from
May 17, 2022
Merged

Fix disappearing "ID mapping" dropdown #6215

merged 3 commits into from
May 17, 2022

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented May 17, 2022

PR fixes a bug where the ÌD Mapping` dropdown of a segmentation layer was hidden when the layer opacity is set to 0.

Possible cause of the bug:

  • Previous versions of the wK UI had the "ID Mapping" dropdown/UI separate of the Segmentation Layer settings. I.e. the ID mapping dropdown had to "disable"/hide itself, when the Segmentation layer was disabled.
  • Since moving the ID mapping setting into the Segmentation layer setting, this behavior is no longer required.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Set Segmentation layer opacity to 0
  • Toggle the segmentation layer to refresh React rendering --> ID mapping dropdown should still be visible
  • Toggle the ID mapping toggle to refresh React rendering --> ID mapping dropdown should still be visible

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this May 17, 2022
@hotzenklotz hotzenklotz enabled auto-merge (squash) May 17, 2022 15:35
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@hotzenklotz hotzenklotz merged commit 409845f into master May 17, 2022
@hotzenklotz hotzenklotz deleted the hidden_mapping branch May 17, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping UI disappears when changing opacity of layer to 0
2 participants