Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unlink fallback layer functionality #6146

Merged
merged 4 commits into from
Apr 20, 2022
Merged

Remove unlink fallback layer functionality #6146

merged 4 commits into from
Apr 20, 2022

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Apr 11, 2022 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open a hybrid annotation with a fallback segmentation layer and check the layer settings. The UI should contain no traces of the "Unlink Fallback Layer" functionality and the remaining buttons should be rendered correctly
  • CI linting should catch dead code

Issues:

(Please delete unneeded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Apr 11, 2022
@daniel-wer
Copy link
Member Author

@philippotto Ping :)

fm3
fm3 approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend LGTM :)

philippotto
philippotto approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :) Sorry for the delay!

@bulldozer-boy bulldozer-boy bot merged commit 81980c3 into master Apr 20, 2022
@bulldozer-boy bulldozer-boy bot deleted the remove-unlink-fallback branch April 20, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

@fm3 fm3 fm3 approved these changes

Assignees

@daniel-wer daniel-wer

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove (broken) "unlinking segmentation layer" feature
3 participants
@daniel-wer @fm3 @philippotto