Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (broken) "unlinking segmentation layer" feature #6137

Closed
daniel-wer opened this issue Apr 6, 2022 · 1 comment · Fixed by #6146
Closed

Remove (broken) "unlinking segmentation layer" feature #6137

daniel-wer opened this issue Apr 6, 2022 · 1 comment · Fixed by #6146
Assignees

Comments

@daniel-wer
Copy link
Member

daniel-wer commented Apr 6, 2022

Todo

Remove the unlinking feature. See the following comment.

Context

I encountered this error on a dev instance and using the current master while trying to unlink a dataset's original segmentation layer in a hybrid annotation.

Expected Behavior

The unlinking should succeed.

Current Behavior

The page ends up in an error state with a red toolbar, showing a toast "Failed to save annotation. Retrying."
Sometimes, another toast with an error message is shown:

Failed to check data access, token may be expired, consider reloading.
Show more information
[Server Time 2022-04-06 11:49]  <~ Unsuccessful WS request to http://localhost:9000/api/tracingstores/localhost/validateUserAccess (ID: 112).Status: 400. Response: {"messages":[{"error":"Annotation couldn¬タルt be found"}]}

Reloading the page shows the annotation with unlinked segmentation layer, so it looks like the action actually succeeded.

Steps to Reproduce the bug

  1. Create a hybrid annotation on a dataset with a segmentation layer.
  2. Select "Unlink a dataset's original segmentation layer" in the layer settings of the segmentation layer

Your Environment for bug

  • Version of WebKnossos (Release or Commit): 22.04.0
@daniel-wer daniel-wer added the bug label Apr 6, 2022
@philippotto philippotto changed the title Unlinking a dataset's original segmentation layer fails Remove (broken) "unlinking segmentation layer" feature Apr 6, 2022
@philippotto
Copy link
Member

I think, the main (only?) use case for this feature was that clicking "create annotation" always created a volume layer with fallback and removing that fallback should be possible somehow. In the meantime, the user can simply click "add volume layer" to get a fresh one. Therefore, I think, we can remove the unlinking feature completely. I renamed the issue therefore. Feel free to veto!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants