Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent ignoring of superfluous save retries #5780

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 14, 2021

A mistake in #3829 broke the feature introduced in #3767 so users with spotty internet connections could provoke wrong 409 CONFLICT errors.
This PR fixes the lookup of the handled group ids

Steps to test:


@fm3 fm3 requested a review from youri-k October 14, 2021 09:29
@fm3 fm3 self-assigned this Oct 14, 2021
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🎉

@fm3 fm3 enabled auto-merge (squash) October 14, 2021 09:34
@fm3 fm3 merged commit 4c2ebc6 into master Oct 14, 2021
@fm3 fm3 mentioned this pull request Oct 14, 2021
6 tasks
@fm3 fm3 deleted the fix-retry-ignore branch October 14, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants