Skip to content

Commit

Permalink
Fix silent ignoring of superfluous save retries (#5780)
Browse files Browse the repository at this point in the history
  • Loading branch information
fm3 authored Oct 14, 2021
1 parent 052a0b2 commit 4c2ebc6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Jobs status is no longer polled if jobs are not enabled, avoiding backend logging spam [#5761](https://github.com/scalableminds/webknossos/pull/5761)
- Fixed a bug that windows user could not open the context menu as it instantly closed after opening. [#5756](https://github.com/scalableminds/webknossos/pull/5756).
- Fixed a bug where the health check of public datasets failed if no cookie/token was supplied. [#5768](https://github.com/scalableminds/webknossos/pull/5768).
- Fixed a bug where retried save requests could lead to a 409 CONFLICT error if the first request was already handled by the back-end. [#5779](https://github.com/scalableminds/webknossos/pull/5779).

### Removed
-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ trait TracingController[T <: GeneratedMessage, Ts <: GeneratedMessage] extends C
updateGroup.transactionId match {
case Some(transactionId) =>
for {
_ <- Fox.assertTrue(tracingService.handledGroupIdStoreContains(transactionId, tracingId, updateGroup.version)) ?~> errorMessage ~> CONFLICT
_ <- Fox.assertTrue(tracingService.handledGroupIdStoreContains(tracingId, transactionId, updateGroup.version)) ?~> errorMessage ~> CONFLICT
} yield updateGroup.version
case None => Fox.failure(errorMessage) ~> CONFLICT
}
Expand Down

0 comments on commit 4c2ebc6

Please sign in to comment.