Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't provide shortcut for comment search #4291

Merged
merged 4 commits into from
Oct 4, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 24, 2019

… to avoid clash with tree-search shortcut. Originally, the idea was to remember which search was used most recently, but the implementation for that would be quite a bit more involved. I think, the solution in this PR is fine, too. The comment search functionality was only added recently and context-sensitive shortcuts might be a bad idea, anyway. Do you agree, @daniel-wer ?

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • place comments and tree tab next to each other and use ctrl+shift+f shortcut. only the search for trees should open

Issues:


@philippotto philippotto self-assigned this Sep 24, 2019
@daniel-wer
Copy link
Member

Hmm, I would prefer a solution where the shortcut would work for both the comment and trees tab if only one of those is visible (and maybe only for the trees tab if both are visible or a message that the shortcut only works if one of the tabs is visible), but I see no easy and straightforward method to accomplish this.
If you don't see a method either, let's merge this and think about it if and when users complain.

@philippotto
Copy link
Member Author

... but I see no easy and straightforward method to accomplish this.
If you don't see a method either, let's merge this and think about it if and when users complain.

Unfortunately, I don't see a good method to do so. Therefore, I'll follow your suggested plan 👍

@bulldozer-boy bulldozer-boy bot merged commit 2e75599 into master Oct 4, 2019
@bulldozer-boy bulldozer-boy bot deleted the avoid-double-search-shortcut branch October 4, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl Shift F opens multiple search dialogs when stacking tabs
2 participants