Don't provide shortcut for comment search #4291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to avoid clash with tree-search shortcut. Originally, the idea was to remember which search was used most recently, but the implementation for that would be quite a bit more involved. I think, the solution in this PR is fine, too. The comment search functionality was only added recently and context-sensitive shortcuts might be a bad idea, anyway. Do you agree, @daniel-wer ?
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Updated migration guide if applicableUpdated documentation if applicableAdapted wk-connect if datastore API changesNeeds datastore update after deployment