Skip to content

Commit

Permalink
Don't provide shortcut for comment search (#4291)
Browse files Browse the repository at this point in the history
* don't provide shortcut for comment search to avoid clash with tree-search shortcut
* adapt tooltip
* update changelog
* Merge branch 'master' of github.com:scalableminds/webknossos into avoid-double-search-shortcut
  • Loading branch information
philippotto authored and bulldozer-boy[bot] committed Oct 4, 2019
1 parent f6bd1af commit 2e75599
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.md).
### Fixed
- When creating tasks from zip, the individual nml names are used again, rather than the zip name. [#4277](https://github.com/scalableminds/webknossos/pull/4277)

### Removed
- Removed the Search shortcut (Ctrl+Shift+F) for comments in the tracing view, since that shortcut collides with the tree search. [#4291](https://github.com/scalableminds/webknossos/pull/4291)

## [19.09.0](https://github.com/scalableminds/webknossos/releases/tag/19.09.0) - 2019-08-28
[Commits](https://github.com/scalableminds/webknossos/compare/19.08.0...19.09.0)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,9 @@ class CommentTabView extends React.PureComponent<PropsWithSkeleton, CommentTabSt
onSelect={comment => this.props.setActiveNode(comment.nodeId)}
data={_.flatMap(this.props.skeletonTracing.trees, tree => tree.comments)}
searchKey="content"
provideShortcut
targetId={commentListId}
>
<ButtonComponent icon="search" title="Open the search via CTRL + Shift + F" />
<ButtonComponent icon="search" title="Search through comments" />
</AdvancedSearchPopover>
<ButtonComponent
title="Jump to previous comment"
Expand Down

0 comments on commit 2e75599

Please sign in to comment.