Circleci-notify: linkify PR number #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstriebel
approved these changes
Nov 20, 2018
| @@ -17,9 +17,13 @@ if [ "${CIRCLE_BRANCH}" == "master" ]; then | |||
| author=${author/valentin-pinkau/<@valentin>} | |||
| channel="webknossos-bots" | |||
| commitmsg=$(git log --format=%s -n 1) | |||
| pullregex="(.*)#([0-9]+)(.*)" | |||
| while [[ $commitmsg =~ $pullregex ]] | |||
There was a problem hiding this comment.
Why do we have the while-loop? I would expect an if. Nothing important, just curious ;)
There was a problem hiding this comment.
I want to replace all occurences of the pattern with the respective linkified version. There are probably nicer ways to do this, but this does the trick. if would only run at most one replacement.
jfrohnhofen
added a commit
that referenced
this pull request
Nov 23, 2018
* origin/master: Optimize performance for the list request /api/datasets (#3441) add annotation dataset foreign key (#3482) thumbnails: correctly use zoom value if specified (#3487) Store Meshes in Postgres (#3367) fix alpha return (#3483) Added script to apply all new evolutions (#3427) Simple fix to speed up dataset gallery (#3480) better errors for screenshot tests, fix imports, refresh screenshots (#3479) (Backend only) Add project priority to progress report json (#3476) Handle missing write access on datastore (#3411) Re-introduce "Flightmode improvements"" (#3473) Circleci-notify: linkify PR number (#3469) Revert "Flightmode improvements" (#3472) also flow-ignore binaryData when using symlinks (#3471) Flightmode improvements (#3392) Circleci custom notification (#3465) enable /api/switch cross-organization (#3464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: