integrate .importjs #3436
Merged
integrate .importjs #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
reviewed
Nov 8, 2018
| import type { DatasetConfiguration } from "oxalis/store"; | ||
| import type { RequestOptions } from "libs/request"; | ||
| import type { NewTask, TaskCreationResponse } from "admin/task/task_create_bulk_view"; | ||
| import type { QueryObject } from "admin/task/task_search_form"; |
There was a problem hiding this comment.
Ah, so if it is only types from one imported file, importjs will put the type in front of the { ... }. In that case, no unnecessary imports should be added by importjs, then :)
There was a problem hiding this comment.
Yeah, I figured that out too after a while :) The only thing which doesn't work well are * imports. E.g., "import * as Utils from ..." cannot be automatically inserted and is also screwed up when using "fix imports" in a file which already does so -.-
However, we only used these in very few places, which is why I rewrote the parts to use more precise imports (arguably better anyway). I'll file an issue at import-js nevertheless.
|
@daniel-wer PR is ready for "review" :) |
Merged
jfrohnhofen
added a commit
that referenced
this pull request
Nov 22, 2018
* master: Fix rgb support (#3455) Fix docker uid/gid + binaryData permissions. Persist postgres db (#3428) Script to merge volume tracing into on-disk segmentation (#3431) Hotfix for editing TaskTypes (#3451) fix keyboardjs module (#3450) Fix guessed dataset boundingbox for non-zero-aligned datasets (#3437) voxeliterator now checks if the passed map has elements (#3405) integrate .importjs (#3436) Re-write logic for selecting zoom level and support non-uniform buckets per dimension (#3398) fixing selecting bug and improving style of layout dropdown (#3443) refresh screenshots (#3445) Reduce the free space between viewports in tracing (#3333) Scala linter and formatter (#3357) ignore reported datasets of non-existent organization (#3438) Only provide shortcut for tree search and not for comment search (#3407) Update Datastore+Tracingstore Standalone Deployment Templates (#3424) In yarn refresh-schema, also invalidate Tables.scala (#3430) Remove BaseDirService that watched binaryData symlinks (#3416) Ensure that resolutions array is dense (#3406) Fix bucket-collection related rendering bug (#3409)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config file for importjs which enables convenient import-magic (javascript only) for IDEs and editors (e.g., "fix all imports" command for the current file).
By default, importjs also orders the imports and groups them by type (e.g., external/internal imports). I'll push a commit in a minute in which I ran importjs on the entire JS codebase. Let's hope, the CI build passes :)