Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In yarn refresh-schema, also invalidate Tables.scala #3430

Merged
merged 3 commits into from
Nov 5, 2018
Merged

In yarn refresh-schema, also invalidate Tables.scala #3430

merged 3 commits into from
Nov 5, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Nov 5, 2018

  • Ready for review

@fm3 fm3 added the backend label Nov 5, 2018
@fm3 fm3 self-assigned this Nov 5, 2018
@fm3 fm3 requested a review from philippotto November 5, 2018 09:18
philippotto
philippotto approved these changes Nov 5, 2018
View reviewed changes
package.json Outdated
@@ -103,7 +103,7 @@
"lint-fix": "node_modules/.bin/eslint --cache --fix --quiet app/assets/javascripts/ tools/",
"flow-coverage": "node_modules/flow-coverage-report/bin/flow-coverage-report.js -i \"./app/assets/javascripts/**/*.js\" -x \"./app/assets/javascripts/test/**/*.js\" -t html -t text",
"docs": "node_modules/.bin/documentation build app/assets/javascripts/oxalis/api/api_loader.js --github --project-name \"webKnossos Frontend API\" --format html --output public/docs/frontend-api",
"refresh-schema": "./tools/postgres/refresh_schema.sh",
"refresh-schema": "./tools/postgres/refresh_schema.sh; rm -f target/scala-2.12/src_managed/schema/com/scalableminds/webknossos/schema/Tables.scala",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, tables.scala will still be deleted even if refresh_schema fails for some reason. If the second step succeeds, the overall exit code will be 0, which is not ideal. I think && would fix this.

@fm3 fm3 merged commit daea36a into master Nov 5, 2018
@fm3 fm3 deleted the refresh-schema-deletes-tables branch November 5, 2018 09:50
jfrohnhofen added a commit that referenced this pull request Nov 22, 2018
@jfrohnhofen
Merge branch 'master' into isosurface
26bb166 
* master:
  Fix rgb support (#3455)
  Fix docker uid/gid + binaryData permissions. Persist postgres db (#3428)
  Script to merge volume tracing into on-disk segmentation (#3431)
  Hotfix for editing TaskTypes (#3451)
  fix keyboardjs module (#3450)
  Fix guessed dataset boundingbox for non-zero-aligned datasets (#3437)
  voxeliterator now checks if the passed map has elements (#3405)
  integrate .importjs (#3436)
  Re-write logic for selecting zoom level and support non-uniform buckets per dimension (#3398)
  fixing selecting bug and improving style of layout dropdown (#3443)
  refresh screenshots (#3445)
  Reduce the free space between viewports in tracing (#3333)
  Scala linter and formatter (#3357)
  ignore reported datasets of non-existent organization (#3438)
  Only provide shortcut for tree search and not for comment search (#3407)
  Update Datastore+Tracingstore Standalone Deployment Templates (#3424)
  In yarn refresh-schema, also invalidate Tables.scala (#3430)
  Remove BaseDirService that watched binaryData symlinks (#3416)
  Ensure that resolutions array is dense (#3406)
  Fix bucket-collection related rendering bug (#3409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @philippotto