Allow user-customizable viewport arrangements #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2295) Move buckets for XY plane on each frame to GPU and render it (status: pixel-perfect for arbitrary xyz and zoomstep).
…er segmentation layer (almost correct)
…ty data to data texture and refresh lookup texture in requestAnimationFrame loop when necessary
…using higher zoom steps
…ing into 512 texture; pass texel coordinates into fragment shader
… set of rendering issues
… when downsampling segmentation; tweak perf of array sorting by using Bose-Nelson network
… loaded; clean up some code and add comments
No, I didn't run into any problems here :) |
…ies; also fix various bugs and clean up
|
@hotzenklotz I completely removed the k/l scaling. The viewport scaling is solely dependent on the available size in a pane (the viewports are still quadratic, though). Do you want to give it another try? |
|
The page is slightly too high in Firefox, leading to this quirky behaviour:
Apart from that, it worked very well for me :) |
hotzenklotz
approved these changes
Jun 1, 2018
daniel-wer
added a commit
that referenced
this pull request
Jun 4, 2018
This reverts commit 46bd8b1.
philippotto
added a commit
that referenced
this pull request
Jun 4, 2018
This reverts commit 5ad7dc6.
philippotto
added a commit
that referenced
this pull request
Sep 17, 2018
* Revert "Revert "Allow user-customizable viewport arrangements (#2570)"" This reverts commit 5ad7dc6. * Revert "Revert "fix node selection; 3d viewport rotation/zooming; fix shortcuts (#2673)"" This reverts commit c95a064. * make gl style static to avoid re-mountings * workaround weird uglifyjs bug which remounts instead of rerenders some react components * re-add snapshots * fix bug which caused hidden arbitrary view to be still rendered * pretty code * tmp: work on different default-layout(s) * Revert "tmp: work on different default-layout(s)" This reverts commit 895c673. * tmp: re-add k/l for custom viewports * pretty code * fix wrong method call * update snapshots * update snapshots * adapt custom viewports to newest master * clean up custom viewports * re-introduce k/l scale value into store; improve UX of custom viewports * fix linting * fix multiple reset and show move-cursor when hovering over tab * add default layoutScaleValue to backend * fix syntax error * update changelog * pretty code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom viewports to WK core. I integrated golden layout and wrote an own react adapter so that the integration is seamless. Arranging of viewports works by only rendering the input catchers into the layout, while the actual canvas is rendered across the entire screen.
Mailable description of changes:
Steps to test:
Issues: