Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor input mouse handling #3475

Open
philippotto opened this issue Nov 20, 2018 · 2 comments
Open

Refactor input mouse handling #3475

philippotto opened this issue Nov 20, 2018 · 2 comments

Comments

@philippotto
Copy link
Member

At the moment, we are manually attaching to a dom node via a selector, which can change (e.g., when the golden layout adapter re-instantiates the layout) though.

philippotto added a commit that referenced this issue Nov 21, 2018
* Revert "Revert "Flightmode improvements" (#3472)"

This reverts commit a775dcd.

* workaround input-mouse issue in volume mode (see #3475)

* fix flow and linting
@daniel-wer
Copy link
Member

This is partly resolved in #4031.
Components which still break because of this (but lower prio):

  • HammerJS touch handling (as hammerjs doesn't seem to support event delegation, but we can probably imitate it)
  • ThreeJS Trackball Controls, i.e. the right click rotation

@philippotto
Copy link
Member Author

See https://github.com/scalableminds/webknossos/pull/5429/files#r621310352 which again gave some attention to this issue. The new FlexLayout lazily renders the input-catchers (so, if the viewport is hidden by the layout it won't be rendered at all). Since we are waiting for these DOM elements, the current approach is a bit sub-optimal (perf-wise and also in general a bit messy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants