Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wk-libs] make network-snapshots for tests readable & idempotent #568

Closed
wants to merge 3 commits into from

Conversation

jstriebel
Copy link
Contributor

Description:

Makes the network-snapshots for tests idempotent and more readable. There's still the exception of webknossos/tests/cassettes/test_examples/test_user_times.yaml which would currently yield user-data and is mostly left as-is for now.

The responses and requests are now adapted, so that

  • zips are unpacked
  • timestamps are filtered
  • tokens are filtered
  • lastUsedByUser is filtered
  • loggedTime is filtered to years <= 2021
  • resumable upload UUIDs are filtered
  • varying metadata content-type: multipart/form-data; boundary=… is filtered

Issues:

@jstriebel jstriebel requested a review from fm3 January 27, 2022 16:11
@jstriebel jstriebel self-assigned this Jan 27, 2022
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add some explaining high-level comments, especially for methods where the name was fixed and is not very descriptive. Looking forward to this change :) (and the next one with the isolated wk instance :D)

webknossos/tests/conftest.py Show resolved Hide resolved
webknossos/tests/conftest.py Show resolved Hide resolved
webknossos/tests/conftest.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants