Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve wk-lib snapshot tests #514

Closed
4 of 6 tasks
jstriebel opened this issue Dec 9, 2021 · 2 comments · Fixed by #656
Closed
4 of 6 tasks

improve wk-lib snapshot tests #514

jstriebel opened this issue Dec 9, 2021 · 2 comments · Fixed by #656
Assignees

Comments

@jstriebel
Copy link
Contributor

jstriebel commented Dec 9, 2021

Currently, some points should be addressed for the wk-lib snapshot tests:

  • Some requests are run against webknossos.org, which might leak user data. For this reason some snapshots are edited manually, which makes it hard to upgrade them.
  • The snapshots contain many timestamps, which makes them change, so that refreshing the snapshots creates large diffs. We should filter those timestamps so that a refresh only shows the necessary changes. There are hooks for this in vcrpy
  • The current version of the local webknossos setup is a bit hidden in the test.sh, maybe we could default to the currently running webknossos.org version?
  • The database should be dropped or evolutions must be run when upgrading the local webknossos setup.
  • The tests should be run regularly without snapshots, e.g. as a nightly test, so that we get notified when webknossos.org has breaking changes we didn't anticipate.
  • __generate_client.py needs some cleanup:
@jstriebel
Copy link
Contributor Author

Also, __generate_client.py needs some cleanup:

  • use isolated wk
  • use extra module for responses
  • use test data
  • integrate into wk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant