add check for dataset name before uploading #545 #555
Conversation
| response = new_dataset_name_is_valid.sync_detailed( | ||
| organization_name=context.organization, | ||
| data_set_name=new_dataset_name, | ||
| client=context.generated_auth_client, | ||
| ) | ||
| assert ( | ||
| response.status_code == 200 | ||
| ), f"Dataset name {context.organization}/{new_dataset_name} does not seem to be valid: {response}" |
There was a problem hiding this comment.
It seem's weird that it's not necessary to update the snapshots, since the upload is also tested. Probably some bug related to the testing, I'll check it when working on #514
There was a problem hiding this comment.
Nevermind, the tests are actually failing due to the tests 🙈 I'll commit an update for those
There was a problem hiding this comment.
@jstriebel ping for cassette update
There was a problem hiding this comment.
It was a bit more complex, please double-check my changes in commit 93f7398. I removed the cloning of the wk-repo and used a docker-compose file instead, where the databases are not persisted anymore. Also, I added some filters for vcr.py, so that the timestamps in some requests are ignored. More cleanup is coming with #514
Description:
__generate_client.pyto work with local webknossos instanceIssues:
Todos:
Make sure to delete unnecessary points or to check all before merging: