Homogenize TASTy printer formatting #19106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Nov 30, 2023
| private def printNames(): Unit = | ||
| sb.append(s"Names (${unpickler.namesEnd.index - unpickler.namesStart.index} bytes, staring from ${unpickler.namesStart.index}):\n") |
There was a problem hiding this comment.
Suggested change
| sb.append(s"Names (${unpickler.namesEnd.index - unpickler.namesStart.index} bytes, staring from ${unpickler.namesStart.index}):\n") | |
| sb.append(s"Names (${unpickler.namesEnd.index - unpickler.namesStart.index} bytes, starting from ${unpickler.namesStart.index}):\n") |
nicolasstucki
force-pushed
the
homogenize-tasty-printer-format
branch
from
6485d2f to
2e4e8fe
Compare
nicolasstucki
force-pushed
the
homogenize-tasty-printer-format
branch
from
2e4e8fe to
a440dc4
Compare
bishabosha
added a commit
that referenced
this pull request
Dec 1, 2023
Based on #19106 Now it properly shows that the sources form the position section are references in the name table. This includes the coloring of the indices and referenced names. ```diff source paths: - 0: t/Test.scala + 0: 21 [t/Test.scala] ``` <img width="272" alt="Screenshot 2023-11-30 at 10 32 35" src="https://github.com/lampepfl/dotty/assets/3648029/36c87ff4-0a21-4af9-907d-1b36d3f70496"> Can be reproduced with ```scala // Test.scala class Test ``` ``` scalac -Yprint-tasty Test.scala ```
* Homogenize the formatting of section names and sizes * Homogenize indentation across sections * Add TASTy header section * Add Names section size
bishabosha
force-pushed
the
homogenize-tasty-printer-format
branch
from
a440dc4 to
448298e
Compare
|
Included in #19106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Old