Fix TASTy source position printer #19105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Homogenize the formatting of section names and sizes * Homogenize indentation across sections * Add TASTy header section * Add Names section size
nicolasstucki
force-pushed
the
fix-tasty-position-printer
branch
from
603196b to
324f1d7
Compare
Now it properly shows that the sources form the position section are references in the name table. This includes the coloring of the indices and referenced names. ```diff source paths: - 0: t/Test.scala + 0: 21 [t/Test.scala] ```
nicolasstucki
force-pushed
the
fix-tasty-position-printer
branch
from
324f1d7 to
931eae4
Compare
nicolasstucki
assigned bishabosha and nicolasstucki and unassigned nicolasstucki and bishabosha
bishabosha
approved these changes
Dec 1, 2023
bishabosha
reviewed
Dec 1, 2023
| sb.append(treeStr("%10d: ".format(addr.index))) | ||
| sb.append(path) | ||
| for ((addr, nameRef) <- sortedPath) { | ||
| sb.append(treeStr("%6d: ".format(addr.index))) |
There was a problem hiding this comment.
@nicolasstucki actually this : should not be highlighted as anything, small thing but it is inconsistent with the rest of the document
There was a problem hiding this comment.
Good catch. I will fix it in #19139
WojciechMazur
added a commit
that referenced
this pull request
Jun 26, 2024
Backports #19105 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #19106
Now it properly shows that the sources form the position section are references in the name table. This includes the coloring of the indices and referenced names.
Can be reproduced with