Scala 2.13.12 (was 2.13.10)

[SethTisue]

No description provided.

[nicolasstucki]

I would add the missing MiMa filter for MapNodeRemoveAllSetNodeIterator.next MiMaFilters.scala StdlibBootstrappedBackwards or StdlibBootstrappedForward. It it seems to be another case where the inferred type is not the same. To solution will be to set this type explicitly in Scala 2.13.

ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.immutable.MapNodeRemoveAllSetNodeIterator.next")

[nicolasstucki]

Maybe we can also remove https://github.com/lampepfl/dotty/blob/main/project/TastyMiMaFilters.scala#L45-L47

[SethTisue]

@nicolasstucki will do

and while I've got your attention, I just noticed that 3.3.1 ships with 2.13.10 stdlib. this is unfortunate — 2.13.11 came out months ago. will this PR fix it for 3.3.2, if I add the "backport requested" label? @Kordyjan maybe you could add this to the Scala 3 release steps, to check that you aren't shipping an out of date Scala 2 stdlib?

[nicolasstucki]

2.13.11 came out months ago. will this PR fix it for 3.3.2, if I add the "backport requested" label?

Yes, but we should double-check if changing this version in a patch release if binary-compatible.

I suspect that this would not be a binary-compatible change due to these incompatibilities:

• https://github.com/lampepfl/dotty/blob/main/project/MiMaFilters.scala#L180-L186
• https://github.com/lampepfl/dotty/blob/main/project/TastyMiMaFilters.scala#L44-L47

Though these appear when compiling the library with Scala 3, which is not yet fully stable. Therefore these could be irrelevant.

[SethTisue]

We have binary compatibility checks in the scala/scala repo, so I believe that should be considered sufficient assurance. All of the 2.13.x stdlibs are known to be both forward and backward compatible with each other.

[SethTisue]

solution will be to set this type explicitly in Scala 2.13

agree. PR: scala/scala#10549

[SethTisue]

Maybe we can also remove main/project/TastyMiMaFilters.scala#L45-L47

Not yet, I don't think, since we're jumping straight from 2.13.10 to 2.13.12 here. (I've changed the PR title to make that more obvious.)

[SethTisue]

Reviewers: if you're wondering why CompletionSuite.scala needed to be updated, well.... it makes sense that languageFeatures.higherKinds would be skipped by completion, because it's deprecated. But we deprecated it way back in 2.13.1, so I don't know why the change would only be showing up here now. It doesn't seem wondering too hard about, since I think it's a progression.

[SethTisue]

@nicolasstucki this is ready for you to take a second look at