Scala 2.13.12 #2897
Merged
Scala 2.13.12 #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philippus
reviewed
Sep 7, 2023
| @@ -120,7 +120,7 @@ with only minor supplements. That's why `versionString` and | |||
| `versionNumberString` report that Scala 2 is in use: | |||
|
|
|||
| ``` | |||
| Welcome to Scala 3.2.0 (17.0.3, Java OpenJDK 64-Bit Server VM). | |||
| Welcome to Scala 3.3.0 (17.0.3, Java OpenJDK 64-Bit Server VM). | |||
| Type in expressions for evaluation. Or try :help. | |||
|
|
|||
| scala> util.Properties.versionNumberString | |||
There was a problem hiding this comment.
there's a line below this one saying val res0: String = 2.13.11.
There was a problem hiding this comment.
Good eye! But I didn't change it because that's what 3.3.0 actually reports, since 3.3.0 predates 2.13.12. Probably the upgrade will land in 3.3.2 and then we can bump it.
I'll add a little note about it, since this is far from obvious.
There was a problem hiding this comment.
Ha, actually the number is too high, not too low! Both 3.3.0 and 3.3.1 use 2.13.10 😢
There was a problem hiding this comment.
Note that I'm pursuing it over at scala/scala3#18525
|
@SethTisue sorry, now I made a merge conflict because the API of 3.3.1 was added |
SethTisue
force-pushed
the
scala-2.13.12
branch
from
3db06f2 to
0e533cd
Compare
|
@bishabosha I'll kill you! 🔪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(should re-run CI after API docs finish publishing)