Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info about importing math.abs #24

Closed
wants to merge 1 commit into from
Closed

Update info about importing math.abs #24

wants to merge 1 commit into from

Conversation

Tschis
Copy link
Contributor

@Tschis Tschis commented Dec 18, 2017

Update info about importing math.abs

If you strictly follow the tutorial, the current code will not compile. You have to either use it as math.abs or import it to be able to use it directly. Since it doesn't mention the import, it can be confusing for beginners.

Update info about importing math.abs
@jdesiloniz
Copy link

@Tschis Hi Rodolfo, thanks for your contribution.

I'd say the issue isn't really the use of Math.abs, as if you notice, we're already defining an abs function at the beginning of the tutorial. IMHO the issue is that the function we're defining is targetting Ints instead of Doubles. Would it be possible for you to change that function and remove the references to Math so the exercise uses the function in the tutorial? It should work that way.

@Tschis
Copy link
Contributor Author

Tschis commented Jan 11, 2018

@jdesiloniz Thank you for your answer.

I had actually forgotten about this PR and deleted my previous fork.
So I had to create a new PR (#26).

This one can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants