-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing abs() to accept Double instead of Int #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! LGTM!
@jdesiloniz Hi! I'm having troubles with the merge because there's an I get:
|
@Tschis Hey! I don't know what could be the cause of your issue with Windows... I tried clonning your repo and bringing the changes from the main one and didn't have any trouble (I'm on OSX). I couldn't push my branch into your repo because of permission issues, but just in case could you try bringing the changes following the steps here? (https://gist.github.com/CristinaSolana/1885435) Thanks! |
@Tschis nevermind, I think we can merge this, as the new change will be on master anyway and your PR doesn't affect those tests. Merging! |
@jdesiloniz Thank you! About the problem: From what I've read, only renaming the folder or cloning it in a docker like container would solve it. |
As requested on #24.
Changing abs() to accept Double instead of Int in FunctionalLoops lesson, which solves compilation problems in isGoodEnough().
@jdesiloniz I needed another PR because I deleted my previous fork.