Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing abs() to accept Double instead of Int #26

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Changing abs() to accept Double instead of Int #26

merged 1 commit into from
Jan 15, 2018

Conversation

Tschis
Copy link
Contributor

@Tschis Tschis commented Jan 11, 2018

As requested on #24.

Changing abs() to accept Double instead of Int in FunctionalLoops lesson, which solves compilation problems in isGoodEnough().

@jdesiloniz I needed another PR because I deleted my previous fork.

Copy link

@jdesiloniz jdesiloniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! LGTM!

@jdesiloniz
Copy link

@Tschis Hi Rodolfo. I've introduced a small change in our tests for this exercise library as one of them was a little bit flaky and it was in the way to make this PR go live: #27.

Could you please update this branch with that change so we are good to merge? Thanks a lot!!

@Tschis
Copy link
Contributor Author

Tschis commented Jan 15, 2018

@jdesiloniz Hi! I'm having troubles with the merge because there's an aux folder in src/main/scala/scalatutorial. Apparently, Windows has problems with that, so my checkout fails.

I get:

fatal: cannot create directory at 'src/main/scala/scalatutorial/aux': Invalid argument

@jdesiloniz
Copy link

@Tschis Hey! I don't know what could be the cause of your issue with Windows... I tried clonning your repo and bringing the changes from the main one and didn't have any trouble (I'm on OSX). I couldn't push my branch into your repo because of permission issues, but just in case could you try bringing the changes following the steps here? (https://gist.github.com/CristinaSolana/1885435)

Thanks!

@jdesiloniz
Copy link

@Tschis nevermind, I think we can merge this, as the new change will be on master anyway and your PR doesn't affect those tests. Merging!

@jdesiloniz jdesiloniz merged commit 4c88910 into scala-exercises:master Jan 15, 2018
@Tschis
Copy link
Contributor Author

Tschis commented Jan 15, 2018

@jdesiloniz Thank you!

About the problem: aux is a reserved word on Windows, so you can't create a folder with that name. Which means Windows users can't clone the repository as it is now.

From what I've read, only renaming the folder or cloning it in a docker like container would solve it.

@jdesiloniz
Copy link

@Tschis I've created a PR to fix that issue, wasn't aware of it! Thanks a lot!! #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants